866947 - nsDocument.cpp:8933:54: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Daniel Holbert [:dholbert] (blocking needinfo/review, due to AFK on parental leave 12/9 - 1/6)]

New build warning:
{
content/base/src/nsDocument.cpp:8933:54: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
                              mImageTracker.Count() < sOnloadDecodeLimit))
                                                      ^
}

sOnloadDecodeLimit is signed, and mImageTracker.Count() is unsigned (from http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/nsBaseHashtable.h#86 )

Comment 1

[Daniel Holbert [:dholbert] (blocking needinfo/review, due to AFK on parental leave 12/9 - 1/6)]

I suspect we should just make this pref an unsigned value. It's a count limit, and a negative count is nonsensical (as is a negative limit on a count).

Comment 2

[Daniel Holbert [:dholbert] (blocking needinfo/review, due to AFK on parental leave 12/9 - 1/6)]

Attachment: fix v1: make sOnloadDecodeLimit unsigned

Comment 3

[Daniel Holbert [:dholbert] (blocking needinfo/review, due to AFK on parental leave 12/9 - 1/6)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b1c9e6a9abce

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b1c9e6a9abce