Open Bug 866955 Opened 8 years ago Updated 7 months ago

"ASSERTION: Placeholder relationship should have been torn down already" with -moz-column, fixed pos

Categories

(Core :: Layout, defect)

x86_64
macOS
defect
Not set
normal

Tracking

()

People

(Reporter: jruderman, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Keywords: assertion, testcase, Whiteboard: [rr])

Attachments

(4 files)

Attached file testcase
###!!! ASSERTION: Placeholder relationship should have been torn down already; this might mean we have a stray placeholder in the tree.: '!placeholder || nsLayoutUtils::IsProperAncestorFrame(aDestructRoot, placeholder)', file layout/generic/nsFrame.cpp, line 620

Same assertion as bug 856269, different testcase.
Attached file stack (gdb)
Attached file frame dump
I think the problem here is that nsBlockFrame::RemoveFrame deletes continuations
in order.  I think it would be more robust if we delete them in reverse order,
like nsContainerFrame::DeleteNextInFlowChild does.

Similarly, the problem in bug 856269 is that we delete the lines in order.

I propose that we make nsBlockFrame::RemoveFrame delete both continuations and
lines in reverse order.  Does anyone see a problem with that?
Fwiw I recorded this on layout/base/crashtests/423107-1.xhtml.
Whiteboard: [rr]
Bug 1110277 patch 3 makes the one annotated occurrence of this in the crashtest suite go away.
Assignee: nobody → karlt
Status: NEW → ASSIGNED
Assignee: karlt → nobody
Blocks: 1198613
Status: ASSIGNED → NEW
Keywords: leave-open
Comment on attachment 8689805 [details] [diff] [review]
annotate 423107-1.xhtml crashtest assertion failure

r=mats
Attachment #8689805 - Flags: review?(mats) → review+
Depends on: 731659
The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?
Flags: needinfo?(svoisen)

The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?

Flags: needinfo?(svoisen)

The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?

Flags: needinfo?(svoisen)
Flags: needinfo?(svoisen)

The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?

Flags: needinfo?(svoisen)
Flags: needinfo?(svoisen)
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.