Closed
Bug 867047
Opened 12 years ago
Closed 12 years ago
remove NS_THEME_TEXTFIELD_CARET
Categories
(Core :: Widget, defect)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: gal, Assigned: gal)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
10.77 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
We only use this on Gtk/Linux, and this complicates bug 866731 where we want to use compositor animation and a color layer to animate the caret. Even on Gtk we probably really want that optimization, so I would say this code path is worth of wholesale deletion (I can make 866731 work with this code in place, but I think the right thing to do is to delete it).
|
Assignee | |
Comment 1•12 years ago
|
||
Assignee: nobody → gal
|
|
Assignee | |
Comment 2•12 years ago
|
||
Note: even on gtk we don't use the widget code to draw the caret if the textfield color is non-standard (CSS set), which is probably pretty much always these days.
|
|
Assignee | |
Updated•12 years ago
|
Attachment #743473 -
Flags: review?(roc)
|
|
Assignee | |
Comment 3•12 years ago
|
||
Actually I will leave the NS_THEME_TEXTFIELD_CARET constant itself. A CSS property depends on it and I don't feel lucky enough to mess with that.
Comment on attachment 743473 [details] [diff] [review]
remove NS_THEME_TEXTFIELD_CARET and gtk implementation of it
Review of attachment 743473 [details] [diff] [review]:
-----------------------------------------------------------------
Makes sense.
Attachment #743473 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
|
||
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•