Closed Bug 867092 Opened 8 years ago Closed 8 years ago
Don't implicitly convert to already
_Add Refed in ns Node Info Manager
No description provided.
Comment on attachment 743549 [details] [diff] [review] Patch > + mTextNodeInfo = nodeInfo = GetNodeInfo(nsGkAtoms::textTagName, nullptr, I am not a huge fan of this. I think I would prefer it if it were written out as: nodeInfo = GetNodeInfo(...); mTextNodeInfo = nodeInfo; // Hold a weak ref; the nodeinfo will let us know // when it goes away and similar for the others. r=me with that
Attachment #743549 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/886b8ddf0611 Green (vis-a-vis this patch) try run: https://tbpl.mozilla.org/?tree=Try&rev=9db698a8c4bb
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.