Closed Bug 867092 Opened 7 years ago Closed 7 years ago

Don't implicitly convert to already_AddRefed in nsNodeInfoManager

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: ayg, Assigned: ayg)

References

Details

Attachments

(1 file)

No description provided.
Flags: in-testsuite-
Attached patch PatchSplinter Review
Attachment #743549 - Flags: review?(bzbarsky)
Comment on attachment 743549 [details] [diff] [review]
Patch

> +    mTextNodeInfo = nodeInfo = GetNodeInfo(nsGkAtoms::textTagName, nullptr,

I am not a huge fan of this.  I think I would prefer it if it were written out as:

  nodeInfo = GetNodeInfo(...);
  mTextNodeInfo = nodeInfo; // Hold a weak ref; the nodeinfo will let us know
                            // when it goes away

and similar for the others.

r=me with that
Attachment #743549 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/886b8ddf0611
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.