Closed
Bug 867092
Opened 12 years ago
Closed 12 years ago
Don't implicitly convert to already_AddRefed in nsNodeInfoManager
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: ayg, Assigned: ayg)
References
Details
Attachments
(1 file)
|
3.13 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Flags: in-testsuite-
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #743549 -
Flags: review?(bzbarsky)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 743549 [details] [diff] [review]
Patch
> + mTextNodeInfo = nodeInfo = GetNodeInfo(nsGkAtoms::textTagName, nullptr,
I am not a huge fan of this. I think I would prefer it if it were written out as:
nodeInfo = GetNodeInfo(...);
mTextNodeInfo = nodeInfo; // Hold a weak ref; the nodeinfo will let us know
// when it goes away
and similar for the others.
r=me with that
Attachment #743549 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/886b8ddf0611
Green (vis-a-vis this patch) try run:
https://tbpl.mozilla.org/?tree=Try&rev=9db698a8c4bb
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•