867295 - Do not use the JSContext to root in parallel code

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: v0

All parallel tests are failing for me currently in an exact rooting build because of push/pop mismatches in the rooting list. I think we should be using the TLS for anything that looks even remotely like parallel code. The parallel tests seem to pass with the attached, at least.

Comment 1

[Niko Matsakis [:nmatsakis]]

Comment on attachment 743754 [details] [diff] [review]
v0

Review of attachment 743754 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, absolutely! This code should have been converted to use the PerThreadData rooting forms long ago, sorry about that.

In many of these cases, the per-thread data is likely available in a ForkJoinSlice* that's hanging around, rather than going through TLS, but basically this looks good.

Comment 2

[Terrence Cole [:terrence]]

Good! I'm glad this is an okay emergency solution. Did you mean to set r+ on the patch?

Comment 3

[Jon Coppeard (:jonco)]

Comment on attachment 743754 [details] [diff] [review]
v0

Review of attachment 743754 [details] [diff] [review]:
-----------------------------------------------------------------

Ah right, looks like I broke this, sorry about that!  Thanks for the heads up.

Comment 4

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a303955db0b5

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a303955db0b5