867325 - Stop hangs caused by the "add a comment" UI showing hundreds of bug suggestions

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Ed Morley [:emorley]]

eg on https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=f99593b42b28&jobname=WINNT 6.2 mozilla-inbound debug test mochitest-3

Easiest thing will be to just remove that part of the UI (ie: the bug numbers listed on the add a comment popup; the suggestions shown in the annotated log summary will be unaffected).

Comment 1

[Ed Morley [:emorley]]

Attachment: Screenshot

Comment 2

[Ed Morley [:emorley]]

Attachment: Patch v1

Comment 3

[Ed Morley [:emorley]]

Thank you :-)

https://hg.mozilla.org/webtools/tbpl/rev/cb4f9cc25a20

Comment 4

[Ed Morley [:emorley]]

In production.

Comment 5

[Ed Morley [:emorley]]

Attachment: Followup

Turns out we needed a little bit of markSuggestedBug() left, so that the "many failure rows showing in the annotated summary, all of which have the same bug suggested" case correctly adds the star next to each, when toggling them via the annotated summary. My local testing did not happen to use oranges that had multi-suggestions like these, hence not spotting til it was in production.

Is only really an aesthetic fix, since the correct bug gets starred, but makes me double-take each time, so going to just land this.

I've intentionally not added back the parts of markSuggestedBug() that dealt with the suggestions in the "add a comment" popup, nor the this.updateAutoStarState() call, since it was actually a duplicate of the call made by the annotated summary onclick event (see SummaryLoader.js init()).

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/webtools/tbpl/rev/9af3474be6d7

Comment 7

[Ed Morley [:emorley]]

Followup in production; multi-selection of same bug number working again.