86734 - Code cleanup for NS_WITH_SERVICE()

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect)

Description

[Cavin Song]

Just a reminder for code cleanup.

Shouldn't be adding code that uses NS_WITH_SERVICE(). So instead of using:

static NS_DEFINE_CID(kStringBundleServiceCID, NS_STRINGBUNDLESERVICE_CID);

NS_WITH_SERVICE(nsIStringBundleService, sBundleService, kStringBundleServiceCID, 
&rv); 

Use the following instead:

nsCOMPtr<nsIStringBundleService> sBundleService =  
do_GetService(NS_STRINGBUNDLE_CONTRACTID, &rv);

Notice that there is no static CID here. The same goes for 
NS_WITH_SERVICE(nsIPref, prefs, kPrefServiceCID, &rv);

A lot of mailnews files have this problem.

Comment 1

[Cavin Song]

Reassign to myself.

Comment 2

[Håkan Waara]

Oh yeah, I've been waiting for something like this.

Comment 3

[Scott MacGregor]

FYI, this isn't too big a deal Cavin, and I would treat this with a very low
priority. Using the NS_WITH_SERVICE macros doesn't break anything and we've got
more important fish to fry right now than to go through and change a bunch of
old callers over.....

Comment 4

[jag (Peter Annema)]

Taking this bug, patch coming up.

Comment 5

[jag (Peter Annema)]

Attachment: [patch] Remove all NS_WITH_SERVICE

Comment 6

[jag (Peter Annema)]

rs=scc

Comment 7

[jag (Peter Annema)]

Filed bugscape bug 7887 for the Netscape side of this.

Updated patch coming up.

Comment 8

[jag (Peter Annema)]

Attachment: [patch] Remove NS_WITH_SERVICE

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

r=dbaron (trusting the perl script, after looking at some nice examples where it
handled all sorts of things correctly)

You probably shouldn't check in nsIServiceManager.h before midnight due to the
closure, and you should definitely post to n.p.m.{seamonkey,xpcom}, and may want
to wait a bit after that although probably not.

Comment 10

[jag (Peter Annema)]

Checked in.

Comment 11

[[e-mail] (gone - use [e-mail] instead)]

verified fixed via code verification (LXR)