867439 - js/src/vm/ArgumentObject.cpp fails to build on non-ION platforms

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Singer (:stevensn)]

When building m-c on a non ION platform (ppc) I get:

...firefox/mozilla-central-hg/src/js/src/vm/ArgumentsObject.cpp
In file included from /media/nfs/usb_drive_src/firefox/mozilla-central-hg/src/js/src/vm/ArgumentsObject.cpp:21:
/media/nfs/usb_drive_src/firefox/mozilla-central-hg/src/js/src/ion/IonFrames.h:290:3: error: #error "unsupported architecture"

I think this was introduced with bug 860145

Comment 1

[Steve Singer (:stevensn)]

Attachment: patch that only includes IonFrames when JS_ION is defined

Comment 2

[Nicolas B. Pierron [:nbp]]

Comment on attachment 743930 [details] [diff] [review]
patch that only includes IonFrames  when JS_ION is defined

Review of attachment 743930 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch and sorry for the trouble.
Do you have commit access?

Comment 3

[Steve Singer (:stevensn)]

No I don't have commit access.  Would you be kind enough to push this for me?

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4ff1e574e509

FYI, the checkin-needed bug keyword is what you're looking for next time :)

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4ff1e574e509