86749 - Changes to LDAP serv properties not honored if composition window open

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P2)

Description

[olga charapaev]

If you change LDAP server properties you autocomplete against while the 
composition window is open, the changes are not reflected until the composition 
window is closed and a new one is open.

Comment 1

[Leif Hedstrom]

This bug is likely to have been fixed by Thursdays checkin.  Can you please see
if it still exists on current builds?

Comment 2

[olga charapaev]

Tried 20010629 trunk builds. The problem is still there.

Comment 3

[Srilatha Moturi]

Attachment: patch v1

Comment 4

[Srilatha Moturi]

ccing ducarroz for r=
ccing sspitzer for sr=

Comment 5

[Jean-Francois Ducarroz]

looks good. R=ducarroz

Comment 6

[(not reading, please use [e-mail] instead)]

1)  style nit:

+        currentAutocompleteDirectory = autocompleteDirectory;
+        if (prevAutocompleteDirectory) {
+          if (prevAutocompleteDirectory != currentAutocompleteDirectory) { 
+            RemoveDirectorySettingsObserver(prevAutocompleteDirectory);
+            AddDirectorySettingsObserver();
+          }
+        }

just do:

if (a && (a != b)) {
  RemoveDirectorySettingsObserver(a);
  AddDirectorySettingsObserver();
}

2)

+        RemoveDirectorySettingsObserver(currentAutocompleteDirectory);
+        currentAutocompleteDirectory = null;

based on that code, shouldn't you be doing that in all places where you call
RemoveDirectorySettingsObserver()?

+        if (prevAutocompleteDirectory) && (prevAutocompleteDirectory !=
currentAutocompleteDirectory) { 
+            RemoveDirectorySettingsObserver(prevAutocompleteDirectory);
+            prevAutocompleteDirectory = null;
+            AddDirectorySettingsObserver();
+        }

and

+    if (currentAutocompleteDirectory) {
+       RemoveDirectorySettingsObserver(currentAutocompleteDirectory);
+       currentAutocompleteDirectory = null;
+    }

Comment 7

[Srilatha Moturi]

1) I can't do this since I have an else in there. Don't do anything if a == b
if (a) { 
  if (a != b)) {
    RemoveDirectorySettingsObserver(a);
    AddDirectorySettingsObserver();
  }
}
else
  AddDirectorySettingsObserver();

2) The following code is part of setupLdapAutocompleteSession()
+        if (prevAutocompleteDirectory) && (prevAutocompleteDirectory !=
currentAutocompleteDirectory) { 
+            RemoveDirectorySettingsObserver(prevAutocompleteDirectory);
+            prevAutocompleteDirectory = null;
+            AddDirectorySettingsObserver();
+        }

Do not have to do this because prevAutocompleteDirectory is set to null in the 
beginning of the function setupLdapAutocompleteSession() and we are not using 
this variable after RemoveDirectorySettingsObserver is called.

+    if (currentAutocompleteDirectory) {
+       RemoveDirectorySettingsObserver(currentAutocompleteDirectory);
+       currentAutocompleteDirectory = null;
+    }

Do not have to do this since teh above code is in ComposeUnload() and we will 
not be using currentAutocompleteDirectory after this call.

Comment 8

[(not reading, please use [e-mail] instead)]

sounds good to me.

sr=sspitzer

Comment 9

[Srilatha Moturi]

Fix checked in

Comment 10

[yulian chang]

Verified with 2001080603 Windows trunck build.