867525 - defect - i cannot bookmark multiple top sites using context app bar

Status: RESOLVED DUPLICATE of bug 867523

(Firefox for Metro Graveyard :: App Bar, defect)

Description

[juan becerra [:juanb]]

Tested on 2013-04-30 using latest nightly built from http://hg.mozilla.org/mozilla-central/rev/dd0c611a0a27

While testing story in bug 831934 I noticed I can select several tiles using the swipe-down gesture and because of that I expect to be able to bookmark all of them at the same time. That's not the case. I tried pinning them too, but that also doesn't work.

This could be a change story or a defect depending on what we decide the user should do in this case. I would opt for being able to bring up this context app bar for one tile.

Steps:
Make sure you have several top site tiles
1. Go to the start page and swipe down on a tile in the list of Top Sites.
2. Swipe down on several more. You can also right click on them.
3. Try bookmarking them, or pinning them.

Expected: You should be able to bookmark or pin them all.

Actual: In the case of pinning them, you will see the little pin icon on the top right of the tile, but they won't actually be pinning in the Windows Start page.

In the case of bookmarks, only the last one will be bookmarked, and it will be bookmarked as an about:start page (captured in bug 867523).

Comment 1

[Sam Foster [:sfoster] (he/him)]

I think we have confusion here about what pinning means as well as a UI ambiguity. 
The context app bar is currently the group (1 or more) of icons that appears on the left of the appbar when you select tiles on the start screen. 

Our Top Sites grid is directly analagous with the grid on about:newtab in desktop. The following actions can be performed on these tiles: 

* Pin at a particular position in the grid (say you want bugzilla.mozilla.org to always be the first top/left tile no matter how often you actually visit it). A pinned tile should have the pinned icon in its top/right corner. This has no relation to pinning sites so they appear on the Windows start screen. 
* Unpin - tiles pinned as described above can be unpinned, so their position in the grid is calculated again by frecency. 

* Block/remove a tile. Removing a Top Sites tile means it should not appear in the grid at all. Although the DB query will include the site it gets filtered out before display. We don't currently have a management UI for blocked sites, and obviously once blocked, a tile no longer appears in the grid so there's no way to select it to unblock it. So, we provide "unblock" as an undo action directly after blocking a tile. Once the selection changes unblock can only be done from about:config - using the browser.newtabpage.blocked pref

* Clear selection - simply unselects selected tiles. 

The other, regular appbar functions like bookmark, pin are *not* contextual to the tile selections. They apply to the current page (about:start in this case). This is probably not clear right now, but I believe will become clearer once the appbar redesign is implemented.