867608 - Gap between forward button and favicon after backing out of reader mode

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Screenshot

STR:

1. Load a page (e.g. http://staktrace.com/spout/)
2. Click on the reader mode icon
3. Click on the back button (either the Android back button or the fennec back button)

Actual results:

There is a gap between the forward button and the favicon (see attached screenshot from Galaxy Tab).

Comment 1

[Aaron Train [:aaronmt]]

Bug 866143? (Should be on Nightly as of 04/30)

Comment 2

[Kartikaya Gupta (email:[e-mail])]

I was testing on the May 01 nightly, so maybe it's not completely fixed. (Testing on tablet in portrait mode, if that makes a difference).

Comment 3

[Lucas Rocha (:lucasr)]

(In reply to Kartikaya Gupta (email:[e-mail], away May2-May20) from comment #2)
> I was testing on the May 01 nightly, so maybe it's not completely fixed.
> (Testing on tablet in portrait mode, if that makes a difference).

Works for me on today's Nightly.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

I'm definitely still seeing this. I just uninstalled and reinstalled Nightly to start with a fresh profile and it still happens. Note that it doesn't happen on initial page load, only after backing out of reader mode as I described in comment 0.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Actually it looks like it happens any time the forward button is visible.

Comment 6

[Aaron Train [:aaronmt]]

tracking for 23+?

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

I also see this on tablets

Comment 9

[Aaron Train [:aaronmt]]

More STR in bug 873086

Comment 10

[Lucas Rocha (:lucasr)]

Attachment: (1/2) Reuse width value on BrowserToolbar's updateForwardButton()

Comment 11

[Lucas Rocha (:lucasr)]

Attachment: (2/2) Fix animation margins for forward button

Comment 12

[Lucas Rocha (:lucasr)]

Pushed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8723dda588e
https://hg.mozilla.org/integration/mozilla-inbound/rev/03ad0762a89c

Comment 13

[Lucas Rocha (:lucasr)]

Comment on attachment 753837 [details] [diff] [review]
(1/2) Reuse width value on BrowserToolbar's updateForwardButton()

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 858687
User impact if declined: Large gap between title and back button in the url bar on 10" tablets whenever the forward button gets hidden
Testing completed (on m-c, etc.): Landed in m-c now, no issues.
Risk to taking this patch (and alternatives if risky): Low, simply removes an obsolete resource for large tablets.
String or IDL/UUID changes made by this patch: n/a

Comment 14

[Lucas Rocha (:lucasr)]

Comment on attachment 753838 [details] [diff] [review]
(2/2) Fix animation margins for forward button

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 858687
User impact if declined: Large gap between title and back button in the url bar on 10" tablets whenever the forward button gets hidden
Testing completed (on m-c, etc.): Landed in m-c now, no issues.
Risk to taking this patch (and alternatives if risky): Low, simply removes an obsolete resource for large tablets.
String or IDL/UUID changes made by this patch: n/a

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a8723dda588e
https://hg.mozilla.org/mozilla-central/rev/03ad0762a89c

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ba0dc50f80d0
https://hg.mozilla.org/releases/mozilla-aurora/rev/5340d1cf6b6d

Comment 17

[Mike Hommey [:glandium]]

This is still happening for me with current nightly.

Comment 18

[Mike Hommey [:glandium]]

(In reply to Mike Hommey (high latency until June 25) [:glandium] from comment #17)
> This is still happening for me with current nightly.

(Asus Transformer TF101)

Comment 19

[Mark Finkle (:mfinkle) (use needinfo?)]

I can no longer reproduce the bug. (Sony Xperia 10.1 tablet)

Comment 20

[Aaron Train [:aaronmt]]

I tried this on a TF201, TF201, and Galaxy Tab 2.0 using Aurora and Nightly (06/03) and couldn't reproduce.

Comment 21

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Build: Firefox for Android 24.0a1( 2013-06-24)
Device: HTC One 
OS: Android 2.3.5

Comment 22

[u421692]

Verified fixed on:
Build: Firefox for Android 23.0b4(2013-07-09)
Device: Acer A500
OS: Android 3.2.1

Comment 23

[Ioana Chiorean]

As per comment comment #21 and comment #22

> Build: Firefox for Android 24.0a1( 2013-06-24)
> Build: Firefox for Android 23.0b4(2013-07-09)

setting the bug to Verified Fixed.