867632 - SimplePush: unregister() calls should not queue up as requests.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

register() and unregister() requests are currently tracked by timers so that a register() DOMRequest is notified of failure if the server cannot be reached or does not reply fast enough. With unregister() being a local call (see PushService.unregister()) for justification, unregister() no longer needs the timer to be used. This is a very simple fix with _sendRequest() replaced by _send().

Comment 1

[Robert Picard]

I'd like to take this one as my first bug.

Comment 2

[Robert Picard]

Attachment: Proposed patch

Comment 3

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Robert,

The patch looks good, but I don't want to land without verifying some things.
I am on vacation till Monday, so I'll probably r+ and land then. Thanks for the patch!

Comment 4

[Robert Picard]

That's no problem. When you do take a look, would you mind letting me know what kinds of things you are verifying? I'd like to get a better idea of how things are tested.

Comment 5

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/307ab52a74fc

I didn't really have to test anything since this was a minor change. I just wanted to verify that that was the only change required. Thanks again for the patch.

Comment 6

[Robert Picard]

No problem. :)

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/307ab52a74fc