867636 - js/src/jscntxt.h:615:46: warning: type attributes ignored after type is already defined [-Wattributes]

Status: RESOLVED WORKSFORME

(Core :: JavaScript Engine, defect)

Description

[Daniel Holbert [:dholbert]]

New GCC build warning (with gcc 4.8):
{
In file included from js/src/jsproxy.cpp:12:0:
js/src/jscntxt.h:615:46: warning: type attributes ignored after type is already defined [-Wattributes]
}
...and similarly, a few lines later:
{
In file included from js/src/jswrapper.cpp:10:0:
js/src/jscntxt.h:615:46: warning: type attributes ignored after type is already defined [-Wattributes]
}

The thing being warned about at line 615 is:
> class JS_FRIEND_API(AutoEnterPolicy);

This seems to be basically a new instance of bug 845868.

Comment 1

[Daniel Holbert [:dholbert]]

From a bit of hg bisecting, it looks like this was introduced by:
{
changeset:   130017:9ab1119d4596
user:        Nicholas Nethercote <[e-mail]>
date:        Tue Apr 23 23:44:36 2013 -0700
summary:     Bug 634839 (part 1) - Remove unnecessary headers (as found by include-what-you-use) from js/src/jsfoo.cpp files.  r=luke.
}
https://hg.mozilla.org/mozilla-central/rev/9ab1119d4596

Comment 2

[Daniel Holbert [:dholbert]]

This happens because AutoEnterPolicy is defined in jsproxy.h, and both of these .cpp files #include jsproxy.h before jscntxt.h.  (in the case of jswrapper, its own .h file has the #include for jsproxy.h)

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: fix v1

One way to fix this is just to #include jscntxt.h in jsproxy.h, so that we'll be guaranteed to see the forward-declaration before the definition.

There may be a better solution, though.

Comment 4

[Daniel Holbert [:dholbert]]

(It looks like this type of warning was reported as a bug to GCC in http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39159 , FWIW... though that was in 2009 and there's been no action on that bug since it was filed.)

Comment 5

[Nicholas Nethercote [inactive]]

I'm pretty sure this isn't present any more.