867650 - Search list still shown on Awesomescreen when clearing search string

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:20.0) Gecko/20100101 Firefox/20.0
Build ID: 20130326150557

Steps to reproduce:

1) Open Awesomescreen
2) Type a search, "abc"
3) Backspace to clear the text


Actual results:

* Awesomescreen still shows the search list for "a"


Expected results:

* Awesomescreen should switch back to Top Sites / Bookmarks / History list

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

This is on latest Nightly, 2013/5/1

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Hmm after playing around more, I've found I cannot repro this initially, but it shows up randomly after interacting with the awesomescreen for a while, and then it becomes consistent. This is on a Galaxy Nexus 4.2.1

Comment 3

[Aaron Train [:aaronmt]]

Attachment: Nightly (05/02) - Screenshot

Here's how I'm able to reproduce on my Nexus 4/Note II

i) Tap the URL bar, enter 'http://mozilla.com' and hit go to visit the site also accept search suggestions
ii) Re-open the url-bar, enter something like 'zzz', then hit backspace on all three characters

The value of the address-bar will show the placeholder text, but the search suggestions will show the same suggestions for the value given; 'z, zillow, zappos, zero dark thirty'.

Comment 4

[Aaron Train [:aaronmt]]

(In reply to Aaron Train [:aaronmt] from comment #3) 
> i) Tap the URL bar, enter 'http://mozilla.com' and hit go to visit the site
> also accept search suggestions

Hm, don't even need to do this; entering 'zzz' and then backspacing is suffice

Comment 5

[:Margaret Leibovic]

I can also reproduce this on a 2.3.6 Nexus S. This must be a recent regression.

Comment 6

[:Margaret Leibovic]

The first bad Nightly was on 4/19. Here's the regression range between Nightly builds:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3ada6a2fd0c6&tochange=64d6d002e888

Comment 7

[:Margaret Leibovic]

This was caused by bug 858340. Confirmed by building with a backout.

I'll look into figuring out how to fix this.

Comment 8

[:Margaret Leibovic]

Attachment: patch

The bug is that we're failing to call mAwesomeTabs.filter when text and mAutoCompleteResult are both empty.

It looks like mAutoCompleteResult is never null, since it's initialized to the empty string, so we should replace the null check with an empty string check.

Comment 9

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/623728226a0d

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/623728226a0d