867675 - Full Screen control in the customization panel doesn't leave the enabled state once it's entered

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Full Screen control in the customization panel doesn't leave the enabled state once it's entered.

STR:
Use the Fullscreen button in the new menu panel
Press the button to enter fullscreen
In fullscreen, press the button to exit fullscreen
Open the menu panel and see that the button is still in the "open" state.

Comment 2

[u428464]

It could be better to have two different icons : one to display in full-screen the other in normal mode. The main difference would be the arrows direction.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

So our theme code for the panel menu only checks for the presence of the 'checked' attribute. However, this is consistent with how much of our theme code works elsewhere in the front-end.

In the case of entering, then exiting, the checked attribute gained the 'false' value, so the attribute was still present and hence the button still showed the checked state.

We could probably get this fixed on mozilla-central now, since it doesn't depend on the customizable UI parts.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 754873 [details] [diff] [review]
Patch

Review of attachment 754873 [details] [diff] [review]:
-----------------------------------------------------------------

Good to go!

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3fa2eb75768d

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3fa2eb75768d