867744 - Intl tests in jstests should not use relative includes

Status: RESOLVED DUPLICATE of bug 977849

(Core :: JavaScript: Internationalization API, defect)

Description

[Christian Holler (:decoder)]

The tests in js/src/tests/test402 seem to use relative loading of helper scripts (using $INCLUDE). We should avoid this behavior at all costs because it breaks fuzzer mutation (the fuzzer has to move the mutated test to a different directory). The proper solution would be to include all the helper functions in the shell.js file.

Comment 1

[Norbert Lindenberg]

"At all costs" could be quite expensive :-)

These tests come from the Test262/Test402 conformance test suite maintained by Ecma TC39, and $INCLUDE is a commonly used mechanism in that test suite. We could modify the import script to add all included scripts into shell.js and browser.js, but then
(a) it would become harder to distinguish Test262/Test402 changes from Mozilla changes, and
(b) every test would load the contents of all include files, increasing the time it takes to run the tests.

Comment 2

[Christian Holler (:decoder)]

What would also work is to INCLUDE using absolute paths instead of relative ones. The jit-test suite does that and passes the absolute path to the libdir as a constant to the tests. I don't know exactly how that can work in the jstests suite however.

Comment 3

[Jeff Walden [:Waldo]]

Does load() have the same problem as loadRelativeToScript(), or no?  It should be fairly easy to make that switch.

Inflating browser.js/shell.js with the full contents of the included files is, as comment 1 notes, not desirable.  If we can't use any sort of loading functionality at all, that's a bit of a problem.

Comment 4

[Christian Holler (:decoder)]

If we have to keep the loads, then I would favor to make the loads absolute, just like the loads in the jit-test suite (with the libdir constant). We could add the same mechanism to the jstests so all tests can use a basepath variable and then add their relative paths to that. It would also require a modification in the fuzzer but it's at least possible to solve it like this.

Comment 5

[Gordon P. Hemsley [:GPHemsley]]

Mass-moving existing Intl-related bugs to the new Core :: JavaScript: Internationalization API component.

If you think this bug has been moved in error, feel free to move it back to Core :: JavaScript Engine.

[Mass change filter: core-js-intl-api-move]

Comment 6

[André Bargull [:anba]]

All $INCLUDE calls were removed as part of bug 977849.