Closed Bug 867903 Opened 7 years ago Closed 6 years ago

Investigate optimizing Configuration.getDescriptors in the Web IDL binding generator

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla24

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file, 1 obsolete file)

After the path in bug 861587, this is in fact an actual hotspot now.  Patch and numbers coming up once I do a bit more measurement.
So for the .BindingGen target from bug 861587, after the patch in that bug, I'm seeing us take about 9.2s all told (that includes the time to load the makefile, etc).

With the patch I'm about to attach, that falls to 7s.

About 2s of that is no-op build overhead for loading the makefile and such, so the actual time spent in codegen drops from about 7.2s to about 5s (split between BindingGen and GlobalGen).
Whiteboard: [need review]
Comment on attachment 744486 [details] [diff] [review]
Speed up getDescriptors and some other obvious slow points in codegen.

The remaining obvious win would be to do both BindingGen and GlobalGen from the same script....
Attachment #744486 - Flags: review?(khuey)
Attachment #744486 - Attachment is obsolete: true
Attachment #744486 - Flags: review?(khuey)
https://hg.mozilla.org/integration/mozilla-inbound/rev/59c279d93f8e
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla23
Target Milestone: mozilla23 → mozilla24
https://hg.mozilla.org/mozilla-central/rev/dbde8ec3af53
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.