Investigate optimizing Configuration.getDescriptors in the Web IDL binding generator

RESOLVED FIXED in mozilla24

Status

()

RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

unspecified
mozilla24
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

After the path in bug 861587, this is in fact an actual hotspot now.  Patch and numbers coming up once I do a bit more measurement.
(Assignee)

Comment 1

6 years ago
So for the .BindingGen target from bug 861587, after the patch in that bug, I'm seeing us take about 9.2s all told (that includes the time to load the makefile, etc).

With the patch I'm about to attach, that falls to 7s.

About 2s of that is no-op build overhead for loading the makefile and such, so the actual time spent in codegen drops from about 7.2s to about 5s (split between BindingGen and GlobalGen).
Whiteboard: [need review]
(Assignee)

Comment 2

6 years ago
Created attachment 744486 [details] [diff] [review]
Speed up getDescriptors and some other obvious slow points in codegen.
(Assignee)

Comment 3

6 years ago
Comment on attachment 744486 [details] [diff] [review]
Speed up getDescriptors and some other obvious slow points in codegen.

The remaining obvious win would be to do both BindingGen and GlobalGen from the same script....
Attachment #744486 - Flags: review?(khuey)
(Assignee)

Comment 4

6 years ago
Created attachment 745492 [details] [diff] [review]
Speed up getDescriptors and some other obvious slow points in codegen.
Attachment #745492 - Flags: review?(khuey)
(Assignee)

Updated

6 years ago
Attachment #744486 - Attachment is obsolete: true
Attachment #744486 - Flags: review?(khuey)
(Assignee)

Comment 5

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/59c279d93f8e
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla23
(Assignee)

Updated

5 years ago
Target Milestone: mozilla23 → mozilla24
https://hg.mozilla.org/mozilla-central/rev/dbde8ec3af53
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.