Closed
Bug 867911
Opened 8 years ago
Closed 8 years ago
Missing defines for non-4k page size platforms
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: martin, Unassigned)
Details
Attachments
(1 file)
597 bytes,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
js/public/HeapAPI.h has a hard coded list of platforms that use non 4kB pages. For sparc64, OpenBSD and NetBSD (at least) are missing in this list. Nit: maybe it would be better to always use 8k pages on sparc64 (and if any other page sizes show up add a negative list)? Anyway, attached patch fixes this problem.
Reporter | ||
Updated•8 years ago
|
Attachment #744489 -
Attachment is patch: true
Attachment #744489 -
Attachment mime type: text/x-patch → text/plain
Comment 1•8 years ago
|
||
Fwiw, i totally gave up having a working ffx on sparc64 since 4.0. 64-bits jsval killed it. Spidermonkey 1.8.5 or 17 build there, but horribly fails at runtime, and firefox sigbuses at startup. After a while, i gave up keeping m-c building there, it was a loss of time. But i don't want to discourage you :)
Reporter | ||
Comment 2•8 years ago
|
||
Yes, we talked about it back then. Shortly afterwards building got impossible, but now I have a state that compiles and am inclined to fix it. Would be great if we can get as much obvious fixes in as they come up.
Comment 3•8 years ago
|
||
Comment on attachment 744489 [details] [diff] [review] Add OpenBSD and NetBSD to list of sparc64 systems with 8k pages Review of attachment 744489 [details] [diff] [review]: ----------------------------------------------------------------- I've been meaning to get Bug 840242 cleaned up and landed. In the meantime, this is a reasonable fix.
Attachment #744489 -
Flags: review+
Updated•8 years ago
|
Whiteboard: [checkin-needed]
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/11bbf55bbad1
Whiteboard: [checkin-needed]
Comment 5•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/11bbf55bbad1
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•