867911 - Missing defines for non-4k page size platforms

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Martin Husemann]

Attachment: Add OpenBSD and NetBSD to list of sparc64 systems with 8k pages

js/public/HeapAPI.h has a hard coded list of platforms that use non 4kB pages. For sparc64, OpenBSD and NetBSD (at least) are missing in this list.

Nit: maybe it would be better to always use 8k pages on sparc64 (and if any other page sizes show up add a negative list)?

Anyway, attached patch fixes this problem.

Comment 1

[Landry Breuil (:gaston)]

Fwiw, i totally gave up having a working ffx on sparc64 since 4.0. 64-bits jsval killed it. Spidermonkey 1.8.5 or 17 build there, but horribly fails at runtime, and firefox sigbuses at startup.
After a while, i gave up keeping m-c building there, it was a loss of time. But i don't want to discourage you :)

Comment 2

[Martin Husemann]

Yes, we talked about it back then. Shortly afterwards building got impossible, but now I have a state that compiles and am inclined to fix it. Would be great if we can get as much obvious fixes in as they come up.

Comment 3

[Terrence Cole [:terrence]]

Comment on attachment 744489 [details] [diff] [review]
Add OpenBSD and NetBSD to list of sparc64 systems with 8k pages

Review of attachment 744489 [details] [diff] [review]:
-----------------------------------------------------------------

I've been meaning to get Bug 840242 cleaned up and landed. In the meantime, this is a reasonable fix.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/11bbf55bbad1

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/11bbf55bbad1