867948 - New SMS via MozActivity not handled correctly

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[:gerard-majax]

Triggering a new SMS from MozActivity with a body while the SMS application is already running somehow does not work.

If the SMS app is already in an opened thread, then the new message compose window is half-displayed and mixed with the thread list.

If the SMS app is alreadi opened on the thread lst, I don't even see the new message compose window.

Code to reproduce: https://gitorious.org/scrapfilbleu/scrapfilbleu/blobs/master/FilATours_HTML5/js/filatours.js#line642

Comment 1

[Rick Waldron [:rwaldron]]

Can you confirm this is fixed or needs additional attention?

(with gaia/master)

Comment 2

[:gerard-majax]

It's not fixed since no one worked on this as far as I can tell.

It's even worse with gaia master from a couple of days old:
E/GeckoConsole(15581): [JavaScript Error: "TypeError: results is null" {file: "app://sms.gaiamobile.org/js/activity_handler.js" line: 50}]

Comment 3

[:gerard-majax]

Please note that the sharing is performed like this https://gitorious.org/scrapfilbleu/scrapfilbleu/blobs/master/FilATours_HTML5/js/filatours.js#line644

    shareJourney: function() {
      var cjd = this._journeyDetailsInfo[this._currentJourneyDetailsId];
      var payload = this.journeyToHuman(cjd);
      var subject = encodeURI(_('steps-subject'));
      console.log("Will share: (" + JSON.stringify(cjd) + ") as (" + payload + ")");
      var a = new MozActivity({
        name: 'new',
        data: {
          url: "mailto:?subject=" + subject + "&body=" + encodeURI(payload), // for emails,
          body: payload, // for SMS
          type: [
            "websms/sms", "mail"
          ]
        }
      });
    },

Comment 4

[:gerard-majax]

After checking a bit, it turns out that it now works well, only if I add an empty "number" field in the payload of my MozActivity. So this error seems to be only related to this missing field.

Comment 5

[Julien Wajsberg [:julienw]]

Alex, if you feel like taking this bug for next week's sprint, please do ;)

Comment 6

[:gerard-majax]

(In reply to Julien Wajsberg [:julienw] from comment #5)
> Alex, if you feel like taking this bug for next week's sprint, please do ;)

Why not, I'll look at this tomorrow.

Comment 7

[Rick Waldron [:rwaldron]]

The good news that we already have all the handling for a "body" param in Message app code, just need to figure out why it doesn't get through

Reference: 
https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/js/activity_handler.js#L35-L67

Comment 8

[:gerard-majax]

(In reply to Rick Waldron from comment #7)
> The good news that we already have all the handling for a "body" param in
> Message app code, just need to figure out why it doesn't get through
> 
> Reference: 
> https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/js/activity_handler.
> js#L35-L67

I have my ideas, I'm starting to hack around in the train :)

Comment 9

[:gerard-majax]

So, basically when the filter is somehow invalid, findBy the method of Contacts defined in contacts.js returns a NULL, as of https://github.com/mozilla-b2g/gaia/commit/e1d70b7

What I'm unsure is why there is this behavior. Is there any specification of the expected behavior somewhere ? If so, then it's the callee's job to ensure we did got a NULL ...

Comment 10

[:gerard-majax]

Attachment: Link to Github https://github.com/mozilla-b2g/gaia/pull/10019

Please find the pull request at https://github.com/mozilla-b2g/gaia/pull/10019

Comment 11

[Julien Wajsberg [:julienw]]

Comment on attachment 754397 [details]
Link to Github https://github.com/mozilla-b2g/gaia/pull/10019

reviewed on github

a small change needed

Comment 12

[Julien Wajsberg [:julienw]]

Comment on attachment 754397 [details]
Link to Github https://github.com/mozilla-b2g/gaia/pull/10019

r=me with the nit fixed

Comment 13

[Alex Keybl [:akeybl]]

We believe this is a regression, so marking as leo+.

Comment 14

[Julien Wajsberg [:julienw]]

master: 1ea8a7e6cc3f918651d60f1c0b7352f9ea9020d6

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 1ea8a7e6cc3f918651d60f1c0b7352f9ea9020d6 to:
v1-train: c36d95181a6c95b4c618cf27ecf51d3dbc61b8f4