Closed
Bug 867950
Opened 12 years ago
Closed 12 years ago
Refactor HTMLInputElement::{Clone,RestoreState,SaveState}() to use GetValueMode() instead of mType
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: mounir, Assigned: mounir)
References
Details
Attachments
(1 file)
6.81 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
When adding a new type, people very often forget to update that method. Using GetValueMode() will make things easier.
Attachment #744568 -
Flags: review?(bugs)
Assignee | ||
Updated•12 years ago
|
Flags: in-testsuite-
Updated•12 years ago
|
Attachment #744568 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 1•12 years ago
|
||
Thanks for this fast review Olli :)
https://hg.mozilla.org/integration/mozilla-inbound/rev/088bb497b532
Target Milestone: --- → mozilla23
Comment 2•12 years ago
|
||
Backed out for mochitest-1 failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/f61587eeaf52
https://tbpl.mozilla.org/php/getParsedLog.php?id=22505418&tree=Mozilla-Inbound
Assignee | ||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c75cee3cbf74
I hate <input type='hidden'>!
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•