Closed
Bug 867966
Opened 12 years ago
Closed 12 years ago
Add a --jobs, -j option to the 'build' command
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla23
People
(Reporter: snorp, Assigned: snorp)
References
(Blocks 1 open bug)
Details
(Whiteboard: [mach])
Attachments
(1 file)
|
4.09 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
I use distcc, so it would be nice to spawn more jobs than the default $NUM_CPUS.
|
Assignee | |
Comment 1•12 years ago
|
||
Assignee: nobody → snorp
|
||
Updated•12 years ago
|
Attachment #744603 -
Flags: review?(gps)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 744603 [details] [diff] [review]
Bug 867966 - Add --jobs,-j option to 'mach build'
Review of attachment 744603 [details] [diff] [review]:
-----------------------------------------------------------------
::: python/mozbuild/mozbuild/mach_commands.py
@@ +45,5 @@
> """Interface to build the tree."""
>
> @Command('build', help='Build the tree.')
> + @CommandArgument('--jobs', '-j', default='0', nargs='?', metavar='jobs', type=int,
> + help='Number of concurrent jobs to run. Default is the number of CPUs')
A few nits:
1) You generally don't need nargs unless you have multiple values.
2) Add a period in the help message.
Attachment #744603 -
Flags: review?(gps) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
|
|
||
Updated•12 years ago
|
Component: mach → Build Config
Whiteboard: [mach]
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•