867971 - no way to reach privacy policy link without toggling the service on/off

Status: VERIFIED FIXED

(Firefox Health Report Graveyard :: Web: Health Report, defect)

Description

[Mike Connor [:mconnor]]

We should fix this before Fx21.  Thanks to Alex Fowler for the spot.

Comment 1

[Schalk Neethling [:espressive]]

(In reply to Mike Connor [:mconnor] from comment #0)
> We should fix this before Fx21.  Thanks to Alex Fowler for the spot.

Unless we add it in say to the status column on the left and, keep the text to simple Privacy Policy, this will create a new string and as fa as I know l10n is in string freeze at the moment.

Comment 2

[Schalk Neethling [:espressive]]

We could potentially also add a footer much in the same style as the one used on mozilla.org but again, this will incur string changes.

Comment 3

[Mike Connor [:mconnor]]

I think it's fine to re-use the string here.  Maybe next to the Learn More... link in the header?

Comment 4

[Laura Thomson :laura]

We can possibly steal "Privacy Policy" as a string from the standard mozilla.org footer.  ccing pascalc for comment.

Comment 5

[Pascal Chevrel:pascalc]

Either take that from mozilla.org or from the Firefox build itself.

Comment 6

[Schalk Neethling [:espressive]]

Opened PR: https://github.com/mozilla/fhr-jelly/pull/80

@lauraxt r?

Comment 7

[Matt Brandt [:mbrandt]]

Attachment: qa - verified on dev

qa verified on dev - the privacy policy link is present both within the service toggle on/off popup as well as outside of the popup. Both privacy policy link correctly point to https://www.mozilla.org/legal/privacy/firefox.html

Verified on nightly; OSX, Win7, and Win8

Comment 8

[Larissa Co [:lco]]

Belated reply, but LGTM... for now (it looks a little weird next to the "Learn More" link, but I think it's not too bad.

As an aside, I'd like to have a bigger discussion about whether we need the privacy policy link on this page, in addition to on the toggle switch. I've been thinking about this recently, and I'm now considering the implications of having one present here.

Some things to consider: 

1. Even though it's web content, FHR is a feature within Firefox. I haven't seen a privacy policy link on other Firefox features besides the link in About: Firefox.

2. The privacy notice is actually about sharing data with Mozilla while the user is using Firefox, not about the user's interaction with the FHR page. If the user turns off sharing, he can still view most of FHR. If anything, It's slightly misleading to have a link to the privacy policy within the FHR feature for this particular use case.

3. We already have a link to the privacy policy from Preferences, and a link to that from the info bar that lets the user know that Mozilla collects some info to provide FHR. We also have a link when the user turns sharing on/off. Potentially, we can have a link in a little blurb that comes up when the user visits FHR for the first time. Isn't all this enough notice? I know we want the user to find our privacy policy easily accessible, but we also don't want to go overboard trying to show that we're not doing anything wrong. It's not like the user is going to keep visiting the privacy policy each and every time they see it, just to make sure we haven't changed it. 

Anyway, worth a longer discussion with Alex and Jishnu, but not worth flip-flopping on the current implementation :)