Closed
Bug 868037
Opened 12 years ago
Closed 12 years ago
GC: Fix more rooting analysis false positives
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: jonco, Assigned: jonco)
References
Details
Attachments
(1 file)
2.37 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
Here's a patch to the analysis for the following:
- js::WeakMap::markIteratively() is called during marking and hence cannot GC
- CustomAutoRooter derived classes not previously counted as AutoRooters
I'm still trying to figure out the best way to get it to not generate a hazard for the AutoRooted StackShape in js::Shape::replaceLastProperty().
Attachment #744670 -
Flags: review?(sphink)
Comment 1•12 years ago
|
||
Comment on attachment 744670 [details] [diff] [review]
Proposed changes
Review of attachment 744670 [details] [diff] [review]:
-----------------------------------------------------------------
Seems fine to me. Note that I plan to land a fix to the GetWeakmapKeyDelegate (+ add some comments) whenever the tree is open next. We can race to see who has to rebase.
::: js/src/devtools/rootAnalysis/annotations.js
@@ +27,5 @@
> // hook called during script finalization which cannot GC.
> if (/CallDestroyScriptHook/.test(caller))
> return true;
>
> + // template method called during marking and hence cannot GC
It'd be nice to come up with something more general for ignoring stuff only called during marking, perhaps based on the AutoSuppressGC stuff, but this is fine.
Attachment #744670 -
Flags: review?(sphink) → review+
Assignee | ||
Comment 2•12 years ago
|
||
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•