Closed
Bug 868065
Opened 11 years ago
Closed 11 years ago
Including GraphicBuffer.h in ImageContainer.h causes ogg to not build on JB
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: mwu, Assigned: mwu)
References
Details
(Whiteboard: [fixed-in-birch])
Attachments
(1 file)
|
872 bytes,
patch
|
vlad
:
review+
|
Details | Diff | Splinter Review |
On JB, hardware/libhardware/include/hardware/hardware.h defines version_minor and version_major which causes OggCodecState.cpp to not build. OggCodecState.h -> MediaDecoderStateMachine.h -> ImageContainer.h -> ui/GraphicBuffer.h -> [other stuff] -> hardware/hardware.h.
ImageContainer.h really doesn't have a good reason to include GraphicBuffer.h - it uses nothing Gonk specific. I moved the include to a place that does need it.
Attachment #744707 -
Flags: review?
|
Assignee | |
Updated•11 years ago
|
Attachment #744707 -
Flags: review? → review?(vladimir)
Attachment #744707 -
Flags: review?(vladimir) → review+
|
|
Assignee | |
Comment 1•11 years ago
|
||
Whiteboard: [fixed-in-birch]
|
||
Comment 2•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•