Closed Bug 868065 Opened 7 years ago Closed 7 years ago

Including GraphicBuffer.h in ImageContainer.h causes ogg to not build on JB

Categories

(Core :: Graphics: Layers, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: mwu, Assigned: mwu)

References

Details

(Whiteboard: [fixed-in-birch])

Attachments

(1 file)

On JB, hardware/libhardware/include/hardware/hardware.h defines version_minor and version_major which causes OggCodecState.cpp to not build. OggCodecState.h -> MediaDecoderStateMachine.h -> ImageContainer.h -> ui/GraphicBuffer.h -> [other stuff] -> hardware/hardware.h.

ImageContainer.h really doesn't have a good reason to include GraphicBuffer.h - it uses nothing Gonk specific. I moved the include to a place that does need it.
Attachment #744707 - Flags: review?
Attachment #744707 - Flags: review? → review?(vladimir)
https://hg.mozilla.org/projects/birch/rev/29e783993171
Whiteboard: [fixed-in-birch]
https://hg.mozilla.org/mozilla-central/rev/29e783993171
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.