868112 - Right side of image is clipped and inaccessible

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Chris Lord [:cwiiis]]

If you have an html e-mail with images in it and you choose "Show external images", the right-side of the image seems to always get clipped. Horizontal scrolling is disabled, so it is inaccessible. Oddly, double-tapping twice to zoom and enable horizontal scrolling still leaves the right side of the image inaccessible as you can only scroll to the end of the flowed text.

In 1.0.1, this is worse as text reflows to the same size as the image, and the same inaccessibility problems remain, but now include text.

I would consider this a blocker - not being able to see the right side of any images in your e-mail is not great.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

It looks like the resizeHandler's call to resizeFrame should probably be resampling the scrollWidth of the iframeBody, updating iframe.style.width so that iframe stops clipping it, and then the viewport will do the right thing too.

We need to get integration tests covering this.


Chris, can you provide the source of the message or manually examine the source and verify that the img tags containing the images do not have height/width attributes or equivalent CSS style directives on them?  I'm assuming that's the case because otherwise our initial layout would be correct and we wouldn't get in this situation.  Also, if you could broadly characterize the source/type of the message and actual image resolutions.


Another possible fix assuming this is the non-explicit image size stuff is to set clobbering style directives on the image to force it to fit on the page and be scaled when explicit size information is lacking rather than letting it blow out the coordinate space.

Comment 2

[Chris Lord [:cwiiis]]

Attachment: An affected e-mail

Here's the source (gotten via Thunderbird) of an affected e-mail.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Thanks for attaching the mail!  I would categorize the e-mail as home-brew newsletter.
- Uses tables, but width is only ever set to 100% rather than an explicit size
- img tags have explicit width attribute, but no height attribute
- some img tags have no src!

I believe for layout purposes our sanitized images' explicit sizing information end up unsized.  We could try and address that somehow, although in cases where only the image's width is provided and not the height, gecko guesses that height=width which turns out to be wrong in this case and makes the message hard to read because of inflated whitespace.

So at least using this e-mail as a data-point, just reconsidering scrollWidth when the images come in seems to be the right thing to do; I would not change our behaviour prior to hitting the show images button.

Comment 4

[Chris Lord [:cwiiis]]

(In reply to Andrew Sutherland (:asuth) from comment #3)
> Thanks for attaching the mail!  I would categorize the e-mail as home-brew
> newsletter.
> - Uses tables, but width is only ever set to 100% rather than an explicit
> size
> - img tags have explicit width attribute, but no height attribute
> - some img tags have no src!

It's not the best markup :) Seems that pretty much all Kickstarter mails go out in this same format, so I guess they have some tool that produces markup like this. Given how popular the site is, probably worth fixing - I think I have other non-Kickstarter mails that are affected though.

Comment 5

[Chris Lord [:cwiiis]]

It seems the text has started reflowing to the images in master now (perhaps this always depended on the mail?), so this is just as bad there as in 1.0.1.

Comment 6

[BMO Automation]

Firefox OS is not being worked on