Add basic support for supporting another gonk base version (JB)

RESOLVED FIXED in mozilla23

Status

defect
RESOLVED FIXED
6 years ago
2 years ago

People

(Reporter: mwu, Assigned: mwu)

Tracking

unspecified
mozilla23
All
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-birch])

Attachments

(1 attachment)

This patch allows us to identify different gonk versions and change the build accordingly. Some basic bits necessary for JB support on the build side are here, along with reducing the number of include paths directly specified in configure.in. I have other patches on the way that will reduce the number of include paths in configure.in on ICS builds.
Attachment #744795 - Flags: review?(mh+mozilla)
Comment on attachment 744795 [details] [diff] [review]
Add basic support for identifying and building for JB

Review of attachment 744795 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +209,5 @@
> +    17)
> +        GONK_INCLUDES="-I$gonkdir/frameworks/native/include"
> +        ;;
> +    *)
> +        AC_MSG_ERROR([Unsupported platform version: \$ANDROID_VERSION])

Does that really work with the backslash?
Attachment #744795 - Flags: review?(mh+mozilla) → review+
(In reply to Mike Hommey [:glandium] from comment #1)
> Comment on attachment 744795 [details] [diff] [review]
> Add basic support for identifying and building for JB
> 
> Review of attachment 744795 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: configure.in
> @@ +209,5 @@
> > +    17)
> > +        GONK_INCLUDES="-I$gonkdir/frameworks/native/include"
> > +        ;;
> > +    *)
> > +        AC_MSG_ERROR([Unsupported platform version: \$ANDROID_VERSION])
> 
> Does that really work with the backslash?

You're right - it doesn't. I was just copying some other code here and didn't realize they meant to print $VARNAME rather than the actual variable. Thanks
https://hg.mozilla.org/projects/birch/rev/d49804cd69d7
Whiteboard: [fixed-in-birch]
https://hg.mozilla.org/mozilla-central/rev/d49804cd69d7
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.