868150 - Add basic support for supporting another gonk base version (JB)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Michael Wu [:mwu]]

Attachment: Add basic support for identifying and building for JB

This patch allows us to identify different gonk versions and change the build accordingly. Some basic bits necessary for JB support on the build side are here, along with reducing the number of include paths directly specified in configure.in. I have other patches on the way that will reduce the number of include paths in configure.in on ICS builds.

Comment 1

[Mike Hommey [:glandium]]

Comment on attachment 744795 [details] [diff] [review]
Add basic support for identifying and building for JB

Review of attachment 744795 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +209,5 @@
> +    17)
> +        GONK_INCLUDES="-I$gonkdir/frameworks/native/include"
> +        ;;
> +    *)
> +        AC_MSG_ERROR([Unsupported platform version: \$ANDROID_VERSION])

Does that really work with the backslash?

Comment 2

[Michael Wu [:mwu]]

(In reply to Mike Hommey [:glandium] from comment #1)
> Comment on attachment 744795 [details] [diff] [review]
> Add basic support for identifying and building for JB
> 
> Review of attachment 744795 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: configure.in
> @@ +209,5 @@
> > +    17)
> > +        GONK_INCLUDES="-I$gonkdir/frameworks/native/include"
> > +        ;;
> > +    *)
> > +        AC_MSG_ERROR([Unsupported platform version: \$ANDROID_VERSION])
> 
> Does that really work with the backslash?

You're right - it doesn't. I was just copying some other code here and didn't realize they meant to print $VARNAME rather than the actual variable. Thanks

Comment 3

[Michael Wu [:mwu]]

https://hg.mozilla.org/projects/birch/rev/d49804cd69d7

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d49804cd69d7