868160 - Remove vendor prefixes from integrated PDF Viewer

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, defect)

Description

[Soumya Deb [:Debloper]]

Integrated PDF viewer does not need any properties with vendor prefixes for which Firefox already uses standardized CSS syntaxes.

ref: https://hacks.mozilla.org/2012/07/aurora-16-is-out/

Comment 1

[Soumya Deb [:Debloper]]

Attachment: v0

Comment 2

[Masatoshi Kimura [:emk]]

Please file an issue and send a PR upstream.
Also, the file is reused for the Web viewer which supports other browsers than Firefox.

Comment 3

[Masatoshi Kimura [:emk]]

That said, we can remove some cargo-cult prefixes. For example, IE and Opera support CSS transitions without prefix from the start.
http://caniuse.com/#search=transition

Comment 4

[Soumya Deb [:Debloper]]

(In reply to Masatoshi Kimura [:emk] from comment #2)
> Please file an issue and send a PR upstream.
WIP, will be ready by tomorrow, or day after.

> Also, the file is reused for the Web viewer which supports other browsers
> than Firefox.
For that reason, my solution (proposed over IRC chat) was to have a mozilla-central branch upstream which is optimized for integration with Firefox releases without unnecessary cross-browser codes (i.e. can have Firefox/Gecko/mozJS specific optimizations to it. Required changes from master can be cherry-picked, if/as required.

Comment 5

[Soumya Deb [:Debloper]]

(In reply to Masatoshi Kimura [:emk] from comment #3)
> That said, we can remove some cargo-cult prefixes. For example, IE and Opera
> support CSS transitions without prefix from the start.
> http://caniuse.com/#search=transition

Should I send a separate pull request for that (if the above scheme sounds okay)?

Comment 6

[Masatoshi Kimura [:emk]]

(In reply to Soumya Deb [:Debloper] from comment #4)
> (In reply to Masatoshi Kimura [:emk] from comment #2)
> > Please file an issue and send a PR upstream.
> WIP, will be ready by tomorrow, or day after.
> 
> > Also, the file is reused for the Web viewer which supports other browsers
> > than Firefox.
> For that reason, my solution (proposed over IRC chat) was to have a
> mozilla-central branch upstream which is optimized for integration with
> Firefox releases without unnecessary cross-browser codes (i.e. can have
> Firefox/Gecko/mozJS specific optimizations to it. Required changes from
> master can be cherry-picked, if/as required.

I'm not sure it's the optimal solution, especially when PDF.js is actively updated due to many rendering bugs. Perhaps we can extend builder.js to remove unneeded prefixes from the generated file.

Comment 7

[Brendan Dahl [:bdahl]]

Comment on attachment 744835 [details] [diff] [review]
v0

Review of attachment 744835 [details] [diff] [review]:
-----------------------------------------------------------------

As discussed on IRC, this needs to happen upstream in the pdf.js project using the build script to strip these out of here or some other similar way.

Comment 8

[Soumya Deb [:Debloper]]

Partial fix: https://github.com/mozilla/pdf.js/pull/3587

Comment 9

[Soumya Deb [:Debloper]]

Not likely that -webkit prefixes will have to be removed anytime soon.
Others are taken care of. It's good to close this bug, IMO.

Comment 10

[Brendan Dahl [:bdahl]]

The webkit ones are stripped out by our build script.