Closed Bug 868215 Opened 7 years ago Closed 7 years ago

add another optgroup / option test

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Details

Attachments

(1 file)

I'm not sure this is all that useful of a test, but I wrote it a while ago to test we got rid of options under <optgrouP> correctly and its been floating around in my pile of patches.
Attachment #744874 - Flags: review?(surkov.alexander)
Comment on attachment 744874 [details] [diff] [review]
add optgroup test

Review of attachment 744874 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/tests/mochitest/treeupdate/Makefile.in
@@ +26,5 @@
>  		test_list.html \
>  		test_listbox.xul \
>  		test_menu.xul \
>  		test_menubutton.xul \
> +  test_optgroup.html \

nit: correct indentation pls

curious if it makes sense to merge it with test_select.html

::: accessible/tests/mochitest/treeupdate/test_optgroup.html
@@ +71,5 @@
> +      this.select = getAccessible(this.selectNode);
> +
> +      this.invoke = function removeOptGroup_invoke()
> +      {
> +this.option1Node = this.selectNode.firstChild.firstChild;

fix indent pls

@@ +88,5 @@
> +              { COMBOBOX_OPTION: [] }
> +            ] }
> +          ] };
> +        testAccessibleTree(this.select, tree);
> +is(isAccessible(this.option1Node), false, "removed option shouldn't be accessible anymore!");

same

@@ +97,5 @@
> +        return "test optgroup's removal from a select";
> +      }
> +    }
> +
> +    gA11yEventDumpToConsole = true;

comment out it

@@ +119,5 @@
> +
> +  <a target="_blank"
> +     href="https://bugzilla.mozilla.org/show_bug.cgi?id=616452"
> +     title="Bug 616452 - Dynamically inserted select options aren't reflected in accessible tree">
> +    Mozilla Bug 616452</a>

nit: no 'Mozilla' pls
Attachment #744874 - Flags: review?(surkov.alexander) → review+
https://hg.mozilla.org/mozilla-central/rev/9414e58bae0b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.