Closed Bug 868230 Opened 9 years ago Closed 6 years ago

Map gamepad X button to show/hide tabs tray

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: bnicholson, Unassigned)

References

Details

Attachments

(1 file)

The tabs panel is a commonly used part of our UI, so it would be nice to have a button dedicated to opening it. This maps X (the OUYA U button) to toggle the tabs tray.
Attachment #744911 - Flags: review?(chrislord.net)
Blocks: ouya
Comment on attachment 744911 [details] [diff] [review]
Map gamepad X button to toggle tabs tray

Review of attachment 744911 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good with first comment addressed. Note that ibarlow had designs where this function was mapped to the left/right triggers, so you may want to talk to him, but I like this mapping and something is better than nothing.

::: mobile/android/base/BrowserApp.java
@@ +911,4 @@
>              return;
>  
>          mTabsPanel.show(panel);
> +        mTabsPanel.requestFocus();

Given that we request focus when showing, do we need to push focus back to the LayerView or the about:home widget when we hide?

@@ +1611,5 @@
>          String profile = GeckoProfile.findDefaultProfile(this);
>          return (profile != null ? profile : "default");
>      }
> +
> +    public void toggleTabs() {

Good call on moving that here, makes more sense.
Attachment #744911 - Flags: review?(chrislord.net) → review+
Assignee: bnicholson → nobody
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.