Closed Bug 868290 Opened 11 years ago Closed 11 years ago

Need to recognize gaia-unit as something other than a generic "U"

Categories

(Tree Management Graveyard :: TBPL, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: philor, Assigned: ewong)

References

Details

Attachments

(1 file, 1 obsolete file)

"b2g_ubuntu32_vm cedar opt test gaia-unit"
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attached patch Add Gaia-unit to tbpl. (v1) (obsolete) — Splinter Review
Attachment #744977 - Flags: review?(emorley)
Blocks: 865379
Comment on attachment 744977 [details] [diff] [review]
Add Gaia-unit to tbpl. (v1)

Thank you for the patch - mostly looks good, just need to:
* Check with how these tests differ from the Gaia UI smoketests, and as such how we should name both (and what symbols to use). Asked in bug 865379 comment 19.
* Remove the "Opt" from the test description, since opt/debug isn't put there - as the symbols/descriptions will be used on any row on TBPL (ie need to be generic).
Attachment #744977 - Flags: review?(emorley)
Comment on attachment 744977 [details] [diff] [review]
Add Gaia-unit to tbpl. (v1)

I think best bet here is to add the unit tests as:
"Gaia Unit Test" : "G"
...and rename the UI tests from "G" to "Gu" - since that way around seems more intuitive.
Attachment #744977 - Attachment is obsolete: true
Attachment #746721 - Flags: review?(emorley)
Comment on attachment 746721 [details] [diff] [review]
Add Gaia-unit to tbpl. (v2)

Looks good, thank you :-)
Attachment #746721 - Flags: review?(emorley) → review+
Depends on: 869831
In production :-)
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: