868302 - Enable rooting LIFO assertions in DEBUG

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

When using Maybe<Rooted> stuff, the LIFO properties are nontrivial to maintain. Always-on asserts (well, at least with DEBUG) would be helpful.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Enable rooting LIFO assertions in DEBUG

Comment 2

[Steve Fink [:sfink] [:s:]]

Comment on attachment 744999 [details] [diff] [review]
Enable rooting LIFO assertions in DEBUG

This is especially important for browser rooting, since we don't have the dynamic analysis there.

Comment 3

[Terrence Cole [:terrence]]

Comment on attachment 744999 [details] [diff] [review]
Enable rooting LIFO assertions in DEBUG

Review of attachment 744999 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent idea! r=me with the name changed.

::: js/src/jspubtd.h
@@ +14,5 @@
>  #include "jsprototypes.h"
>  #include "jstypes.h"
>  
> +#if defined(JSGC_ROOT_ANALYSIS) || defined(JSGC_USE_EXACT_ROOTING) || defined(DEBUG)
> +# define JSGC_ROOT_STACK

This name does not really indicate well what's going on here. How about JSGC_KEEP_EXACT_ROOTS to match JSGC_USE_EXACT_ROOTING?

Comment 4

[Terrence Cole [:terrence]]

(In reply to Terrence Cole [:terrence] from comment #3)
> This name does not really indicate well what's going on here. How about
> JSGC_KEEP_EXACT_ROOTS to match JSGC_USE_EXACT_ROOTING?

Actually I guess JSGC_TRACK_EXACT_ROOTS would be even better.

Comment 5

[Steve Fink [:sfink] [:s:]]

I had some weird problems where my local build worked but tbpl ones didn't, but there was something bizarre going on with my local setup then.

Now this bug is blocked on LIFO bugs it uncovers in the browser rooting, for at least 2 different reasons.

Comment 6

[Steve Fink [:sfink] [:s:]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/e61603f64470

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e61603f64470