868321 - Sites with no stylesheets just show loading indicator forever

Status: RESOLVED FIXED

(DevTools :: Style Editor, defect)

Description

[Heather Arthur [:harth]]

Go to any university professor's website (like http://www.history.ucsb.edu/faculty/marcuse/). It won't have any CSS. Load the Style Editor and see that it just shows the spinning loading indicator instead of letting you know there aren't any style sheets.

This is a regression from bug 816967. A testcase should be added for it as well.

Comment 1

[Heather Arthur [:harth]]

Attachment: Show 'no style' message if there aren't any sheets on page load +test

This patch reverts this regression. The remote style editor was individually sending 'stylesheet-added' events with no concept of document load, in anticipation of bug 839103. It now has a 'document-load' event with all the stylesheets available on the page load, so that we can check if there are none.

We can add back 'stylesheet-added' events when bug 839103 is fixed, right now it has no real use.

Comment 2

[Heather Arthur [:harth]]

Attachment: show 'no style sheets' indicator - rebased

Rebased after bug 740541

Comment 3

[Heather Arthur [:harth]]

https://hg.mozilla.org/integration/fx-team/rev/ea2b0db82289

Comment 4

[Joe Walker [:jwalker]]

https://hg.mozilla.org/mozilla-central/rev/ea2b0db82289