Sites with no stylesheets just show loading indicator forever

RESOLVED FIXED in Firefox 23

Status

DevTools
Style Editor
RESOLVED FIXED
5 years ago
7 days ago

People

(Reporter: harth, Assigned: harth)

Tracking

unspecified
Firefox 23

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Go to any university professor's website (like http://www.history.ucsb.edu/faculty/marcuse/). It won't have any CSS. Load the Style Editor and see that it just shows the spinning loading indicator instead of letting you know there aren't any style sheets.

This is a regression from bug 816967. A testcase should be added for it as well.
(Assignee)

Comment 1

5 years ago
Created attachment 745716 [details] [diff] [review]
Show 'no style' message if there aren't any sheets on page load +test

This patch reverts this regression. The remote style editor was individually sending 'stylesheet-added' events with no concept of document load, in anticipation of bug 839103. It now has a 'document-load' event with all the stylesheets available on the page load, so that we can check if there are none.

We can add back 'stylesheet-added' events when bug 839103 is fixed, right now it has no real use.
Assignee: nobody → fayearthur
Attachment #745716 - Flags: review?(dcamp)
(Assignee)

Comment 2

5 years ago
Created attachment 746651 [details] [diff] [review]
show 'no style sheets' indicator - rebased

Rebased after bug 740541
Attachment #745716 - Attachment is obsolete: true
Attachment #745716 - Flags: review?(dcamp)
Attachment #746651 - Flags: review?(dcamp)

Updated

5 years ago
Attachment #746651 - Flags: review?(dcamp) → review+
https://hg.mozilla.org/mozilla-central/rev/ea2b0db82289
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 23

Updated

7 days ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.