868385 - [Building Blocks] Input fields should be updated to the latest version

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Sergi]

Attachment: New Input areas

Comment 1

[Sergi]

Input fields have been updated in the Common Controls file: https://www.dropbox.com/s/xaohxz39nh9ft7u/CommonControls_20130305.jpg 

we should update the building block to match this update.

Comment 2

[Sergi]

Attachment: New Input fields

Comment 3

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: Patch

Comment 4

[Ismael Gonzalez [:basiclines]]

Comment on attachment 749864 [details]
Patch

You can merge as soon as the addressed comments are fixed.
Thx for your hard work!

Comment 5

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Ismael, thanks for your comments, I have addressed them.
I have also done some fixes in Music app to adapt them to the new visual styles.

Comment 6

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Dominic, could you please check if changes in Music app work for you.
I have changed the input areas Building block, and that visually modifies your search boxes.
Thanks.

Comment 7

[Dominic Kuo [:dkuo]]

(In reply to arnau from comment #6)
> Dominic, could you please check if changes in Music app work for you.
> I have changed the input areas Building block, and that visually modifies
> your search boxes.
> Thanks.

arnau, thanks for working on this, you patch works fine in Music, but the rounded x button seems not working. I haven't look on your patch in detail but I guess it just need some tweak to fix that, and is this bug solves bug 862321 as well?

Comment 8

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Dominic, could you please check that again? the clear icon works for me (resets what I type in the input) in unagi with latest build.
About bug 862321 the new Building Block solves it partially.
You will still need to remove the close button when not in search mode (First capture in https://bug862321.bugzilla.mozilla.org/attachment.cgi?id=742260)
Thanks.

Comment 9

[Dominic Kuo [:dkuo]]

arnau, after I tested again on device, it works now. But I just realized in comment 7 I tested on desktop client, it still doen't work and I don't know why. Do you also encounter this issue on your desktop client?

Comment 10

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Dominic, it work in my Nightly as well, so will merge this.
Thanks!

Comment 11

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Commit: 0a6b5fb302f048422c505c5b283ad2fde8091952

Comment 12

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 749864 [details]
Patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Not matching UX visual designs
Testing completed: 
Risk to taking this patch (and alternatives if risky):low, just changed CSS styles and images
String or UUID changes made by this patch:

Comment 13

[Alex Keybl [:akeybl]]

(In reply to arnau from comment #12)
> Risk to taking this patch (and alternatives if risky):low, just changed CSS
> styles and images

This impacts all input fields - is the risk actually low? Our other partners block on minor polish issues, some of which this may introduce.

Comment 14

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

This only impacts in Music and Contacts app, as this change is only for a type of input: search box. I have checked both apps and they are ok.

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x  0a6b5fb302f048422c505c5b283ad2fde8091952
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 16

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Done!
v1-train: c523791afd5772a276b67e776839bef0748b9c55