868398 - [Contacts][Settings] Adjust text paddings

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Sergi]

Attachment: Correct padding :: screenshot

The padding shpuld be of 15px each side for dividers and buttons, and 30px for text. The distance from one button to the next one should be 10px, and from the last button to the next section 15px.

Comment 1

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Attachment: Current contact settings screen on Gaia master

This is how the contact settings screen looks on a recent Gaia master (bbd6e46084370f3aee54231695880bb702299710) in my Unagi phone. Isn't that how it is supposed to look? Can anybody confirm or tell me how to reproduce the scenario with bad padding?

Comment 2

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

looks like facebook icon is bigger now

Comment 3

[Sergi]

Yes, the facebook icon should be smaller, and the distance between buttons and some paddings are not correct. You should use 20px from the subheader to the button, 10px in between buttons and 20px from the last button no the next subheader.

The horizontal paddings are perfect: 15px for the button and 30px for text inside the button.

Comment 4

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Hi Arnau, Is this still relevant?

Comment 5

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Yes, is still relevant (should be 30x30px as the others)

Peter,
Could you please provide a proper icon to replace the current one?
Thanks

Comment 6

[Peter La]

Attachment: Facebook Icons for Contact Settings and List

Hi Arnau,

Attached are the icons in 30x30 format.  I will get Eric and Amy to provide higher res versions.

Comment 7

[Peter La]

Attachment: ScreenshotWithUpdatedIcon.png

Screenshot showing updated icon.

Comment 8

[Eric Pang [:epang] UX]

Attachment: Facebook icons @1.5x

Hi, I've attached the icon at 1.5x.  I have not included a 2x version since they are no longer needed for the tablet. Let me know if anything else is needed.  Thanks!

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

This is outdated for 1.3/1.4 ... can we close this now?

Comment 10

[Eric Pang [:epang] UX]

yes, thanks for checking Naoki!

Comment 11

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Closing because it's outdated.