868406 - Need to Shutdown MediaStreamGraph's thread

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

MediaStreamGraphImpl::ShutdownThreads exists but is never called.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/be3cef4b69e3

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Backed out:

https://hg.mozilla.org/integration/mozilla-inbound/rev/e5972785237b
https://hg.mozilla.org/integration/mozilla-inbound/rev/a081cfffeed0

for thread safety assertions on Windows XP and 7:

https://tbpl.mozilla.org/php/getParsedLog.php?id=22605157&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=22604913&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=22605215&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=22604946&tree=Mozilla-Inbound

and test failures on OSX:

https://tbpl.mozilla.org/php/getParsedLog.php?id=22605176&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=22606107&tree=Mozilla-Inbound

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://tbpl.mozilla.org/?tree=Try&rev=c44317abfd43

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c9737a4136cf

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c9737a4136cf