Closed
Bug 868460
Opened 12 years ago
Closed 12 years ago
Tidy up animation bits
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 23
People
(Reporter: lucasr, Assigned: lucasr)
Details
Attachments
(5 files)
2.09 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
3.58 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
980 bytes,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
17.55 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
13.04 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #745248 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #745249 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 3•12 years ago
|
||
Attachment #745250 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #745251 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 5•12 years ago
|
||
Attachment #745252 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 6•12 years ago
|
||
(In reply to Lucas Rocha (:lucasr) from comment #2)
> Created attachment 745249 [details] [diff] [review]
> (2/5) Mark views to have transient state while animating
FYI: this will probably fix bug 811739 for devices with Jelly Bean and later. Marking views as having transient state while animating means the views will not be recycled until the animation ends. That's how TwoWayView works. The same applies to ListView and GridView.
Updated•12 years ago
|
Attachment #745248 -
Flags: review?(mark.finkle) → review+
Updated•12 years ago
|
Attachment #745249 -
Flags: review?(mark.finkle) → review+
Updated•12 years ago
|
Attachment #745250 -
Flags: review?(mark.finkle) → review+
Comment 7•12 years ago
|
||
Comment on attachment 745251 [details] [diff] [review]
(4/5) Replace AnimatorProxy calls with ViewHelper ones
I was a little concerned by calling AnimatorProxy.create(view); so much, but I see a proxy is mostly returned right away.
I suppose this cleans up the code enough to be OK. I'm usually not a fan of "too many layers".
Attachment #745251 -
Flags: review?(mark.finkle) → review+
Updated•12 years ago
|
Attachment #745252 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 8•12 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #7)
> Comment on attachment 745251 [details] [diff] [review]
> (4/5) Replace AnimatorProxy calls with ViewHelper ones
>
> I was a little concerned by calling AnimatorProxy.create(view); so much, but
> I see a proxy is mostly returned right away.
>
> I suppose this cleans up the code enough to be OK. I'm usually not a fan of
> "too many layers".
Agree on "too many layers sucks". The reason for this patch is twofold: 1) I never intended to make AnimatorProxy a public API, it's just an implementation details behind our little animation framework 2) ViewHelper reduces verbosity and code duplication quite a bit.
The only case where ViewHelper is less efficient than original code is when you set multiple properties on the same view (in which case we have to get the respective AnimatorProxy more than once).
Assignee | ||
Comment 9•12 years ago
|
||
Pushed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ece17aed454c
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa4f3e24bca4
https://hg.mozilla.org/integration/mozilla-inbound/rev/85c771c2fffd
https://hg.mozilla.org/integration/mozilla-inbound/rev/0881dcd9a86c
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7919d0dd4f2
Comment 10•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ece17aed454c
https://hg.mozilla.org/mozilla-central/rev/fa4f3e24bca4
https://hg.mozilla.org/mozilla-central/rev/85c771c2fffd
https://hg.mozilla.org/mozilla-central/rev/0881dcd9a86c
https://hg.mozilla.org/mozilla-central/rev/c7919d0dd4f2
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•