868497 - Movistar Recomienda's app manifest is invalid, so orientation lock will fail as a result

Status: RESOLVED WONTFIX

(Tech Evangelism Graveyard :: Preinstalled B2G Apps, defect)

Description

[Jason Smith [:jsmith]]

The preinstalled app - movistar recomienda has an invalid app manifest - orientation does not belong under the permissions property.

{
  "name": "Recomienda",
  "description": "Recomendador de app y servicios de Movistar",
  "version": "1.0",
  "launch_path": "/index.html",
   "developer": {
    "name": "Movistar",
    "url": "http://www.movistar.es"
  },
  "default_locale": "es",
  "locales": {
    "es": {
      "name": "Recomienda",
      "description": "Recomendador de app y servicios de Movistar",
      "developer": {
        "name": "Movistar",
        "url": "http://www.movistar.es"
      }
    }
  },
 "icons": {
    "128": "/style/icons/icon_128.png",
    "60": "/style/icons/icon_60.png"
  },
"permissions": {
  "geolocation": {
    "description": "Required to customize the aplication list to the final customer"
  },
  "orientation": "portrait-primary"


}
}

This exists both in the hosted app manifest and the app preinstalled on device:

- http://www.movistarrecomienda.es/app/manifest.webapp
- https://github.com/telefonicaid/firefoxos-gaia-spain/blob/master/external-apps/recomienda/manifest.webapp

Comment 1

[Jason Smith [:jsmith]]

Not sure how critical this is for the app to have orientation lock. Will nom defensively just in case.

Comment 2

[Jason Smith [:jsmith]]

This requires a fix on the app developer's side and changes to the preinstalled app repository to fix this.

Karen - Can someone do some outreach here to fix this problem?

Comment 3

[Julien Wajsberg [:julienw]]

I think Yuren is the one doing this usually.

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

I prefer update manifest from 3rd party developer then we re-generate repository again.

BTW, rex wrote a makefile[1] for generating external-app/* to make life easier.

https://github.com/telefonicaid/firefoxos-gaia-spain/blob/master/Makefile

Comment 5

[Julien Wajsberg [:julienw]]

So yuren this should be assigned to you ?

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Sure.

Karen, please contact 3rd party developer for updating their manifest.

Comment 7

[Lisa Brewster [:adora]]

Developer notified.

Also note that this app has not yet passed app review.  It was last submitted on April 22 and rejected on April 25.

Comment 8

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

I can modify manifest on firefoxos-gaia-spain, but it will be replaced when we re-generate all apps.

Comment 9

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Fixed.

https://github.com/telefonicaid/firefoxos-gaia-spain/commit/97d8aa30dd1a996d2b498c6547eb70881349b306

Karen, please make sure 3rd party developer know this problem.

Comment 10

[Andrew Williamson [:eviljeff]]

(In reply to Yuren Ju [:yurenju] from comment #9)
> Fixed.
> 
> https://github.com/telefonicaid/firefoxos-gaia-spain/commit/
> 97d8aa30dd1a996d2b498c6547eb70881349b306
> 
> Karen, please make sure 3rd party developer know this problem.

see comment #7

Comment 11

[Jason Smith [:jsmith]]

Note that this only fixed on the partner app customization, not in the hosted app. So right now, given that we update very quickly, this won't do anything as a stand-alone. Reopening on that basis to await the update on the app developer's side.

Comment 12

[Jason Smith [:jsmith]]

This app has been pulled from the grid.