Closed Bug 868571 Opened 12 years ago Closed 11 years ago

Update marketplace packaged app to include the mobile network permission to allow for SIM access

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:tef+, b2g18 fixed, b2g18-v1.0.1 fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g tef+
Tracking Flags:
Tracking Status
b2g18 --- fixed
b2g18-v1.0.1 --- fixed

People

(Reporter: jsmith, Assigned: cvan)

References

Details

(Whiteboard: [status: needs uplift] QARegressExclude)

Attachments

(1 file)

Pointer to Github Pull Request: https://github.com/mozilla-b2g/gaia/pull/9827
91 bytes, text/html
julienw
: review+
jsmith
: feedback+
Details
Update the marketplace packaged app on device to include the mobilenetwork permission to allow for SIM access. This is required for 1.01 to allow for country-specific content at marketplace.
Depends on: 866272
blocking-b2g: --- → tef?
Blocks: 867793
Waiting on bug 866272 to be uplifted before we can do this.
Alex, Lukas, I think the blocking decision is in your hands in this case.
Flags: needinfo?(lsblakk)
Whiteboard: [tef-triage]
The packaged app was already delivered. I think this is done already.
(In reply to Wil Clouser [:clouserw] from comment #3) > The packaged app was already delivered. I think this is done already. Was it landed as part of the gaia build?
(In reply to Jason Smith [:jsmith] from comment #4) > (In reply to Wil Clouser [:clouserw] from comment #3) > > The packaged app was already delivered. I think this is done already. > > Was it landed as part of the gaia build? No, I don't think so. Ignore my comment.
Wil - are you the right person to land this in tree?
Assignee: nobody → clouserw
blocking-b2g: tef? → tef+
Chris mentioned in IRC he is looking into this right now.
(In reply to Jason Smith [:jsmith] from comment #7) > Chris mentioned in IRC he is looking into this right now. -> cvan then. Thanks Chris!
Assignee: clouserw → cvan
Whiteboard: [tef-triage] → [status: needs landing][tef-triage]
ETA: 3.5 hours
Flags: needinfo?(lsblakk)
Attachment #750810 - Flags: review?(felash)
Whiteboard: [status: needs landing][tef-triage] → [status: needs review][tef-triage]
Keywords: checkin-needed
Whiteboard: [status: needs review][tef-triage] → [status: needs review]
Keywords: checkin-needed
Comment on attachment 750810 [details] Pointer to Github Pull Request: https://github.com/mozilla-b2g/gaia/pull/9827 r=me with changing |type:"web"| to |type:"privileged"|; not absolutely sure this is needed (I think that for packaged app we reload them from the manifest) but better be safe than sorry given the timeframe we have here
Attachment #750810 - Flags: review?(felash) → review+
Keywords: checkin-needed
Hold up. This needs a one line fix before landing. See comment 12.
Keywords: checkin-needed
Comment on attachment 750810 [details] Pointer to Github Pull Request: https://github.com/mozilla-b2g/gaia/pull/9827 Nit that was asked to be fixed is fixed. Carrying Julien's r+ forward.
Attachment #750810 - Flags: feedback+
Now we can land this.
Keywords: checkin-needed
John, can you land this please?
Flags: needinfo?(jhford)
Whiteboard: [status: needs review] → [status: needs landing]
master: 7adf61a
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(jhford)
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [status: needs landing] → [status: needs uplift]
Uplifted 7adf61abfa6f6894997374ff75c668b5d6620ad3 to: v1-train: cabe966ce651abe15a53fe40ed732c56f8d3a12e v1.0.1: 46e1a5d016a8bd7d0d2eddcdb38b6e07d3a4a515
status-b2g18: affected → fixed
status-b2g18-v1.0.1: affected → fixed
Whiteboard: [status: needs uplift] → [status: needs uplift] QARegressExclude
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: