Closed Bug 868634 Opened 7 years ago Closed 6 years ago

Remove compartment entry for nsStructureCloneContainer

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(1 file)

No description provided.
I can't see what this is supposed to be doing. The one caller defaults to aCx,
and if not, gets and pushes a context associated with the document, restoring
it to the default compartment.

So this only changes the behavior when we use the aCx that comes in from above,
in which case it's totally not clear to me why we would want to get the default
global here.
Attachment #745409 - Flags: review?(bzbarsky)
Comment on attachment 745409 [details] [diff] [review]
Remove compartment entry in nsStructuredCloneContainer. v1

Yeah, this looks cargo-culted...
Attachment #745409 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/ea66aac44f31
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.