If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove compartment entry for nsStructureCloneContainer

RESOLVED FIXED in mozilla23

Status

()

Core
DOM
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bholley, Assigned: bholley)

Tracking

unspecified
mozilla23
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
Created attachment 745409 [details] [diff] [review]
Remove compartment entry in nsStructuredCloneContainer. v1

I can't see what this is supposed to be doing. The one caller defaults to aCx,
and if not, gets and pushes a context associated with the document, restoring
it to the default compartment.

So this only changes the behavior when we use the aCx that comes in from above,
in which case it's totally not clear to me why we would want to get the default
global here.
Attachment #745409 - Flags: review?(bzbarsky)
Comment on attachment 745409 [details] [diff] [review]
Remove compartment entry in nsStructuredCloneContainer. v1

Yeah, this looks cargo-culted...
Attachment #745409 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea66aac44f31
https://hg.mozilla.org/mozilla-central/rev/ea66aac44f31
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.