868644 - Put the StoreBuffer method definitions in the right namespace

Status: RESOLVED WORKSFORME

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: v0

I forgot to prefix all of the names with js::gc:: when declaring them. I'm surprised none of our current compilers complain about it.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I don't think you need this because there's a "using js::gc" at the top of the file. Consider:

JS_ALWAYS_INLINE HeapSlot *
StoreBuffer::SlotEdge::slotLocation() const
{
...
}

When the compiler sees this, it tries to look up the name "StoreBuffer". It finds it in js::gc because of the using declaration. In contrast, consider this code:

void
SomeFunction()
{
...
}

In this case, if you wanted SomeFunction to be in js::gc, you would need to qualify it. The difference is that, in the first example, the compiler is looking up a pre-existing name (StoreBuffer), while in this case something new is being defined.

Comment 2

[Terrence Cole [:terrence]]

Ah, that makes sense! I figured something like that must be happening in practice since this code obviously compiles; I just wasn't sure if it was something we could depend on.