868652 - 3 Contacts unit tests fail on TBPL

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Jonathan Griffin (:jgriffin)]

First error:

14:57:24     INFO -  gaia-unit-tests TEST-UNEXPECTED-FAIL | suggestion Bar #update suggestions by contact data - 1 data | Contacts.findListByNumber is not a function
14:57:24     INFO -  gaia-unit-tests INFO       | stack trace:
14:57:24     INFO -      TypeError: Contacts.findListByNumber is not a function
14:57:24     INFO -          at sb_updateByContacts (http://communications.gaiamobile.org:8080/dialer/js/suggestion_bar.js:70)
14:57:24     INFO -          at callback (http://communications.gaiamobile.org:8080/dialer/js/suggestion_bar.js:62)
14:57:24     INFO -          at load (http://communications.gaiamobile.org:8080/dialer/test/unit/mock_lazy_loader.js:4)
14:57:24     INFO -          at sb_update (http://communications.gaiamobile.org:8080/dialer/js/suggestion_bar.js:60)
14:57:24     INFO -          at (anonymous) (http://communications.gaiamobile.org:8080/dialer/test/unit/suggestion_bar_test.js:127)
14:57:24     INFO -          at wrapper (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:62)
14:57:24     INFO -          at run (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709)
14:57:24     INFO -          at runTest (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081)
14:57:24     INFO -          at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127)
14:57:24     INFO -          at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007)
14:57:24     INFO -          at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016)
14:57:24     INFO -          at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964)
14:57:24     INFO -          at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3979)
14:57:24     INFO -          at done (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3700)
14:57:24     INFO -          at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3712)
14:57:24     INFO -          at (anonymous) (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:46)
14:57:24     INFO -          at wrapper (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:73)
14:57:24     INFO -          at run (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709)
14:57:24     INFO -          at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973)
14:57:24     INFO -          at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984)
14:57:24     INFO -          at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932)

Full log:

https://tbpl.mozilla.org/php/getParsedLog.php?id=22568249&tree=Cedar&full=1#error8

Comment 1

[Julien Wajsberg [:julienw]]

This specific problem is caused by Bug 867421 that should land hopefully soon.

We'll probably have more when that bug is fixed (because I think this hides more failures) but we need to wait for this first.

Comment 2

[Julien Wajsberg [:julienw]]

Bug 867421 is fixed, now we have more failing tests, but they are real failures instead ! So we can fix them !

Comment 3

[Dietrich Ayala (:dietrich)]

Thanks Julien - who's the best person to fix these? I will help to find their time.

Comment 4

[Julien Wajsberg [:julienw]]

I think there is no failure anymore for this, therefore I'm closing.