868673 - Fix -Wtype-limits "comparison of unsigned expression >= 0 is always true" warning in XPFE

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[Chris Peterson [:cpeterson]]

Attachment: fix-type-limit-warning.patch

When compiling with gcc 4.7 for Android, I get the following warning in XPFE code because `zLevel` is unsigned and `lowestZ` is a 0 constant. ToInteger() returns a signed int, so I changed `zLevel` to be signed, too.

xpfe/appshell/src/nsXULWindow.cpp: In member function 'bool nsXULWindow::LoadMiscPersistentAttributesFromXUL()':
xpfe/appshell/src/nsXULWindow.cpp:1249:46: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]

Comment 1

[[e-mail]]

Comment on attachment 745435 [details] [diff] [review]
fix-type-limit-warning.patch

ToInteger returns an int32_t, so this makes sense. Otherwise you have to start fiddling around with asserting that lowestZ is zero, which isn't worth it.

Comment 2

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/03b869365923

https://tbpl.mozilla.org/?tree=Try&rev=7fd8a54b39cf

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/03b869365923

Comment 4

[Firefox Bug Husbandry Bot]

Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336