868681 - Offline apps doorhanger not shown

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Geoff Brown [:gbrown]]

The offline apps doorhanger:

  Allow %S to store data on your device for offline use?

is not shown when offline storage is requested.

Logcat shows:

E/GeckoConsole(24773): [JavaScript Error: "ReferenceError: chromeWin is not defined" {file: "chrome://browser/content/OfflineApps.js" line: 45}]

Looks like a recent regression, from bug 854940.

Comment 1

[Geoff Brown [:gbrown]]

Attachment: define gChromeWin

Copied the lazy getter code used in aboutAddons.js -- works for me and allows robocop's (currently disabled) testDoorHanger to succeed.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 745453 [details] [diff] [review]
define gChromeWin

This was a bad review on my part. OfflineApps is injected into the browser.js scope, so BrowserApp.manifest should work fine without the need for a "chromeWindow".

Try this line:
     let requestor = BrowserApp.manifest ? "'" + BrowserApp.manifest.name + "'" : host;

Comment 3

[Geoff Brown [:gbrown]]

Attachment: eliminate chromeWin reference

That's better, and works just as well - thanks!

Comment 4

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/61a824c4e122

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/61a824c4e122

Comment 6

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
-build: Firefox for Android 23.0a1(2013-05-12)
-device: Samsung Galaxy Nexus
-OS: Android 4.1.1