868723 - Resources added from the manifest always use linkTemplate

Status: RESOLVED FIXED

(L20n :: HTML Bindings, defect)

Description

[Staś Małolepszy :stas]

Because we always try to replace {{lang}} and we use replace.bind, the argument to ctx.linkResource is a bound function and link always calls linkTemplate.

With changes from https://github.com/l20n/l20n.js/commit/70852bc5572a0fb8f3f5f6d6062d4d64f7a70b1a to how we add resources, this means that resources from the manifest are never added to _none.  If they are simple strings, they should.

   The summary of the (add|link)Resource logic is as follows (`y` means "the
   method adds resources to this locale or these locales"):

                                 _none   _locales
        addResource                y
        linkResource(string)       y         y
        linkResource(function)               y

Comment 1

[Staś Małolepszy :stas]

Let's just test if {{lang}} is in the resource URI.  I'll have a patch in a few, together with some code clean-up from bug 868454.

Comment 2

[Staś Małolepszy :stas]

Attachment: Patch

This patch conflicts with bug 868719.  Depending on which one lands first, I'll rebase the other one.

Comment 3

[Staś Małolepszy :stas]

https://github.com/l20n/l20n.js/commit/69a3885323600b3282667503387a22f66fb55e19