868727 - Pass an nsAString to nsGlobalWindow::GetChildWindow

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

I don't think we should be using jsids here.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 745510 [details] [diff] [review]
Patch v1

Could you file a followup bug to make the nsDependentJSString constructor take a Handle<jsid>, perhaps?  Bonus points for fixing it.  ;)

r=me

Comment 2

[[e-mail]]

Comment on attachment 745510 [details] [diff] [review]
Patch v1

>+nsGlobalWindow::GetChildWindow(const nsAString& aName)
>+{
>   nsCOMPtr<nsIDocShellTreeNode> dsn(do_QueryInterface(GetDocShell()));
>   NS_ENSURE_TRUE(dsn, nullptr);
> 
>   nsCOMPtr<nsIDocShellTreeItem> child;
>-  dsn->FindChildWithName(reinterpret_cast<const PRUnichar*>(chars),
>+  dsn->FindChildWithName(PromiseFlatString(aName).get(),
All the callers pass an nsString of some sort, so if you make aName const nsString& you can just call .get() directly.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/c2df00e9434f