Closed
Bug 868785
Opened 12 years ago
Closed 12 years ago
Fix rooting hazards in TestStartupCache.cpp
Categories
(Toolkit :: Startup and Profile System, defect)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
1.90 KB,
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #745595 -
Flags: review?(tschneidereit)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 745595 [details] [diff] [review]
Patch (v1)
Review of attachment 745595 [details] [diff] [review]:
-----------------------------------------------------------------
::: startupcache/test/TestStartupCache.cpp
@@ +438,5 @@
> return NS_ERROR_UNEXPECTED;
> }
>
> for (uint32_t i = 0; i < before_size; ++i) {
> + JS::RootedValue before_num(cx), after_num(cx);
Nit: Rooted* should be declared outside of loops to reduce their overhead. Obviously not important at all here, though ...
Attachment #745595 -
Flags: review?(tschneidereit) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
|
||
Comment 3•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•