Closed Bug 868851 Opened 7 years ago Closed 7 years ago

Click-to-play controls in add-ons managed don't behave like normal menulists

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: neil, Assigned: neil)

References

Details

(Keywords: access)

Attachments

(1 file)

Because the selected item is always disabled, and disabled items are always hidden (by use of the addon-control class), the selected item is always hidden, which is incorrect behaviour for menulists, particularly in the case of the Mac or third-party theme which wants to indicate the selected item, and also with regards to accessibility, for instance scrolling through the options with the keyboard doesn't work.
Attached patch Proposed patchSplinter Review
It would also look odd for the selected item to be visible but disabled, so I just force-enable the selected item, which also makes it visible, which suffices to make the menulist operate normally. (Enabling the selected item doesn't cause a problem because setting userDisabled to its current value is short-circuited in the setter.)
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #745676 - Flags: review?(bmcbride)
Comment on attachment 745676 [details] [diff] [review]
Proposed patch

Review of attachment 745676 [details] [diff] [review]:
-----------------------------------------------------------------

Ugh, good point.

This doesn't break any tests? It, uh, probably should have... guess browser_CTP_plugins.js is missing checks for that. Bonus points if you want to modify that test, but I don't see a need to hold up this bug to add tests that should have been covered by another bug.
Attachment #745676 - Flags: review?(bmcbride) → review+
(In reply to Blair McBride from comment #2)
> This doesn't break any tests?
Tests? Apparently not: https://tbpl.mozilla.org/?tree=Try&rev=73e8376dc0e9

https://hg.mozilla.org/integration/mozilla-inbound/rev/dbe30ba57be1
https://hg.mozilla.org/mozilla-central/rev/dbe30ba57be1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.