868851 - Click-to-play controls in add-ons managed don't behave like normal menulists

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[[e-mail]]

Because the selected item is always disabled, and disabled items are always hidden (by use of the addon-control class), the selected item is always hidden, which is incorrect behaviour for menulists, particularly in the case of the Mac or third-party theme which wants to indicate the selected item, and also with regards to accessibility, for instance scrolling through the options with the keyboard doesn't work.

Comment 1

[[e-mail]]

Attachment: Proposed patch

It would also look odd for the selected item to be visible but disabled, so I just force-enable the selected item, which also makes it visible, which suffices to make the menulist operate normally. (Enabling the selected item doesn't cause a problem because setting userDisabled to its current value is short-circuited in the setter.)

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 745676 [details] [diff] [review]
Proposed patch

Review of attachment 745676 [details] [diff] [review]:
-----------------------------------------------------------------

Ugh, good point.

This doesn't break any tests? It, uh, probably should have... guess browser_CTP_plugins.js is missing checks for that. Bonus points if you want to modify that test, but I don't see a need to hold up this bug to add tests that should have been covered by another bug.

Comment 3

[[e-mail]]

(In reply to Blair McBride from comment #2)
> This doesn't break any tests?
Tests? Apparently not: https://tbpl.mozilla.org/?tree=Try&rev=73e8376dc0e9

https://hg.mozilla.org/integration/mozilla-inbound/rev/dbe30ba57be1

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dbe30ba57be1