Convert ImageDocument to WebIDL

RESOLVED FIXED in mozilla23

Status

()

RESOLVED FIXED
6 years ago
8 days ago

People

(Reporter: peterv, Assigned: peterv)

Tracking

(Blocks: 1 bug)

Trunk
mozilla23
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Attachment #746069 - Flags: review?(bzbarsky)
(Assignee)

Comment 2

6 years ago
Attachment #746071 - Flags: review?(bzbarsky)
Comment on attachment 746069 [details] [diff] [review]
Move class into a header v1

r=me
Attachment #746069 - Flags: review?(bzbarsky) → review+
Comment on attachment 746071 [details] [diff] [review]
Switch to WebIDL v1

>+interface ImageDocument : HTMLDocument {

[NoInterfaceObject], please.

Might be worth a followup to make these all [ChromeOnly], or at least try to.

r=me with that.
Attachment #746071 - Flags: review?(bzbarsky) → review+
Comment on attachment 746072 [details] [diff] [review]
Move PostCreateWrapper into nsIDocument::WrapObject v1

r=me

This needs one more patch to drop the hasXPConnectImpls bits from HTMLDocument and Document in the conf file, right?
Attachment #746072 - Flags: review?(bzbarsky) → review+
Comment on attachment 746069 [details] [diff] [review]
Move class into a header v1

>--- a/content/html/document/src/ImageDocument.cpp
>+++ b/content/html/document/src/ImageDocument.h
>@@ -1,78 +1,27 @@
> /* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
> /* This Source Code Form is subject to the terms of the Mozilla Public
>  * License, v. 2.0. If a copy of the MPL was not distributed with this
>  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>+#ifndef ImageDocument_h___
>+#define ImageDocument_h___

Please do not add a new symbol containing two (or more) consecutive underscores.
(Assignee)

Comment 9

6 years ago
(In reply to Boris Zbarsky (:bz) from comment #5)
> [NoInterfaceObject], please.
> 
> Might be worth a followup to make these all [ChromeOnly], or at least try to.

There's one place in chrome where we |instanceof nsIImageDocument|. It'd be nice to be able to remove that interface (it's unused in our code otherwise) but still allow chrome to do something like that. Maybe we should have ChromeOnly interface objects (and make that mean "all properties are ChromeOnly too")?
And a few places where we do |instanceof ImageDocument|, fwiw
Comment on attachment 746307 [details] [diff] [review]
Drop hasXPConnectImpls from documents v1

r=me, yay!
Attachment #746307 - Flags: review?(bzbarsky) → review+
Er, wait.  Why is there a window.ImageDocument right now, if the interface is not named nsIDOMImageDocument?  Is this more classinfo suck?  :(

If we already have a window.ImageDocument, I guess we're at least not making things worse... but yes, having a way to flag the entire interface as ChromeOnly would be nice.
(Assignee)

Comment 13

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/249001348a81
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f162188fed4
https://hg.mozilla.org/integration/mozilla-inbound/rev/b87e943e0ab3
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a86629a8fa2

(In reply to Boris Zbarsky (:bz) from comment #12)
> Er, wait.  Why is there a window.ImageDocument right now, if the interface
> is not named nsIDOMImageDocument?  Is this more classinfo suck?  :(

CutPrefix deals with both nsIDOM* and nsI* prefixes, and we apply it to all interfaces on a primary prototype chain I think.

Updated

6 years ago
Blocks: 869825
Blocks: 885177
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.