869006 - Comment should be constructable

Status: RESOLVED FIXED

Description

[Erik Arvidsson]

http://dom.spec.whatwg.org/#comment

Make Comment constructable so that one can do "new Comment('abc')" instead of "document.createComment('abc')"

Comment 1

[Andrea Marchesini [:baku]]

Created attachment 747919 [details] [diff] [review]
patch

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 747919 [details] [diff] [review]
patch

Review of attachment 747919 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/Comment.cpp
@@ +64,5 @@
> +Comment::Constructor(const GlobalObject& aGlobal, const nsAString& aData,
> +                     ErrorResult& aRv)
> +{
> +  nsCOMPtr<nsPIDOMWindow> window = do_QueryInterface(aGlobal.Get());
> +  nsRefPtr<Comment> comment = new Comment(window->GetDoc()->NodeInfoManager());

Null-check window and window->GetDoc()

::: content/base/test/test_bug869006.html
@@ +20,5 @@
> +
> +/** Test for Bug 869006 **/
> +
> +var c = new Comment();
> +ok(c, "Comment has been created without content");

Test c.data.

@@ +23,5 @@
> +var c = new Comment();
> +ok(c, "Comment has been created without content");
> +
> +c = new Comment('foo');
> +ok(c, "Comment has been created");

Here too

Comment 3

[Andrea Marchesini [:baku]]

Created attachment 747928 [details] [diff] [review]
patch

Comment 4

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Once you know window and doc are not null, why not just call createComment on the doc?

Comment 5

[Andrea Marchesini [:baku]]

https://tbpl.mozilla.org/?tree=Try&rev=78c025a6f8e5

Comment 6

[Andrea Marchesini [:baku]]

Created attachment 748022 [details] [diff] [review]
patch

green on try

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 748022 [details] [diff] [review]
patch

Review of attachment 748022 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3411817d911f

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3411817d911f

Comment 10

[Jean-Yves Perrier [:teoli]]

Docs:
https://developer.mozilla.org/en-US/docs/Web/API/Comment
https://developer.mozilla.org/en-US/docs/Web/API/Comment.Comment
and
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/24