869095 - Bump in-tree mozdevice to 0.25

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[William Lachance (:wlach)]

For parity with talos, when we upgrade the version of mozdevice used by that.

Comment 1

[William Lachance (:wlach)]

Attachment: Diff for bumping mozdevice

Not much going on here, since we landed gbrown's recent changes seperately for convenience. The only slightly confusing thing is that getTopActivity is changed. This is because of some 5-space indentation in droid.py which was probably accidental. I don't think this is worth doing another versionbump for, but I will fix it in mozbase itself for next timearound. Since it's just a formatting correction to a previous patch, I don't think review is required.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 745980 [details] [diff] [review]
Diff for bumping mozdevice

Review of attachment 745980 [details] [diff] [review]:
-----------------------------------------------------------------

did we miss version 0.23 ?

Comment 3

[William Lachance (:wlach)]

Meh, actually let's bump things again after all. May as well only have to suffer all this confusion once.

Comment 4

[William Lachance (:wlach)]

Attachment: Bump to 0.25

This should be exactly the same as the previous without the getTopActivity difference (since I fixed that discrepancy inside mozbase itself)

Comment 5

[William Lachance (:wlach)]

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=c18e67ee6939

Comment 6

[William Lachance (:wlach)]

(In reply to Joel Maher (:jmaher) from comment #2)
> Comment on attachment 745980 [details] [diff] [review]
> Diff for bumping mozdevice
> 
> Review of attachment 745980 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> did we miss version 0.23 ?

Yeah, there were some accidental commits last week which I only noticed after versionbumping. So I reverted stuff, then did a new release.

Comment 7

[William Lachance (:wlach)]

Comment on attachment 745987 [details] [diff] [review]
Bump to 0.25

Since this is essentially the same patch as before (+ some formatting fixes), I'll carry over the r+.

Comment 8

[William Lachance (:wlach)]

Try run looked good, pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/86cdfca59c81

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/86cdfca59c81