Closed Bug 869095 Opened 7 years ago Closed 6 years ago

Bump in-tree mozdevice to 0.25

Categories

(Testing :: Mozbase, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla23

People

(Reporter: wlach, Assigned: wlach)

Details

Attachments

(1 file, 1 obsolete file)

For parity with talos, when we upgrade the version of mozdevice used by that.
Attached patch Diff for bumping mozdevice (obsolete) — Splinter Review
Not much going on here, since we landed gbrown's recent changes seperately for convenience. The only slightly confusing thing is that getTopActivity is changed. This is because of some 5-space indentation in droid.py which was probably accidental. I don't think this is worth doing another versionbump for, but I will fix it in mozbase itself for next timearound. Since it's just a formatting correction to a previous patch, I don't think review is required.
Attachment #745980 - Flags: review?(jmaher)
Comment on attachment 745980 [details] [diff] [review]
Diff for bumping mozdevice

Review of attachment 745980 [details] [diff] [review]:
-----------------------------------------------------------------

did we miss version 0.23 ?
Attachment #745980 - Flags: review?(jmaher) → review+
Meh, actually let's bump things again after all. May as well only have to suffer all this confusion once.
Summary: Bump in-tree mozdevice to 0.24 → Bump in-tree mozdevice to 0.25
Attached patch Bump to 0.25Splinter Review
This should be exactly the same as the previous without the getTopActivity difference (since I fixed that discrepancy inside mozbase itself)
Attachment #745980 - Attachment is obsolete: true
(In reply to Joel Maher (:jmaher) from comment #2)
> Comment on attachment 745980 [details] [diff] [review]
> Diff for bumping mozdevice
> 
> Review of attachment 745980 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> did we miss version 0.23 ?

Yeah, there were some accidental commits last week which I only noticed after versionbumping. So I reverted stuff, then did a new release.
Comment on attachment 745987 [details] [diff] [review]
Bump to 0.25

Since this is essentially the same patch as before (+ some formatting fixes), I'll carry over the r+.
Attachment #745987 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/86cdfca59c81
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.